Fix overriding termination in GA class #505
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I remember setting this caused issues with other algorithms. This would require some testing. Did you have a chance to check if this change has any unwanted side-effects? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the code could not set a termination condition using the termination argument in the Algorithm class when using the GA subclass.
I saw that the standard procedure is to set a default termination condition if it is unset, but in the GA class, after calling super().__init__, no matter the termination argument set, the termination variable is later overridden.
With this PR, the code using GA with a termination condition worked as expected.
I had yet to check other algorithms or tests. I publish this PR with little care, but I am okay with someone suggesting checking more to get this right.
P.S.: Thank you for publishing and maintaining this package. It is very useful.