Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specs to be run with Docker #201

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dukenguyenxyz
Copy link
Contributor

Description

This PR will allow developers to run clear specs using Docker instead of installing PostgreSQL on their local system. Containerisation will not only help developers test clear without having to install PostgreSQL but also to allow for reproducibility due to the elimination of environmental differences.

In the future, this small change can be upgraded to setting up an entire docker-compose environment so that developers can run clear and clear specs without having to install either PostgreSQL or Crystal, this configuration can also be used for the CI/CD pipeline.

Motivation and Context

How Has This Been Tested?

  • All specs passed

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Manual of usage of the new feature.

Checklist:

  • My code follows the code style of this project. bin/ameba ran without alert.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@dansbits
Copy link

dansbits commented Feb 1, 2022

Looks like this was proposed a while ago and I don't see any conversation. Any chance running specs in Docker in the future?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants