Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget reload failing after playback starts #891

Closed
MoojMidge opened this issue Aug 25, 2024 · 8 comments
Closed

Widget reload failing after playback starts #891

MoojMidge opened this issue Aug 25, 2024 · 8 comments

Comments

@MoojMidge
Copy link
Collaborator

          I'd say this looks pretty good - no problems so far: [kodi.log](https://github.com/user-attachments/files/16739840/kodi.log)

But maybe you could take a look at why the corresponding widget always disappears after starting a video from the widget? The problem has existed for a very long time and occurs with all of my skins and only with the YT addon: kodi_widget.log

Originally posted by @C-O-D in #888 (comment)

@MoojMidge
Copy link
Collaborator Author

For how long has this been happening?

@C-O-D
Copy link

C-O-D commented Aug 25, 2024

For how long has this been happening?

I'd say since early this year or something, don't know exactly
Thanks for your great work btw :-)

@MoojMidge
Copy link
Collaborator Author

When Kodi plays or stops something it will refresh the current list container. Ostensibly this is done to ensure that the watched status of the played item is updated in the list, but Kodi will actually refresh all open list containers, all at once, including any widgets you have open.

This can actually cause Kodi to crash, so there is a crash workaround that was implemented in this plugin to cancel the plugin invocation if it was likely to trigger this crash.

Unfortunately this will mean that the widget which is filled by the plugin will effectively be empty and, depending on the skin, may be collapsed/hidden.

The crash workaround is not a perfect solution and has a number of side effects, including what you have noticed, but it does cut down on the number of crashes.

There is an updated version of the crash workaround that will probably work a bit better in this situation. Will add it into the next beta and you can see if it resolves this problem.

@C-O-D
Copy link

C-O-D commented Aug 25, 2024

Great, thank you very much for the detailed explanation and of course for your efforts 👍

MoojMidge added a commit to MoojMidge/plugin.video.youtube that referenced this issue Aug 26, 2024
@MoojMidge
Copy link
Collaborator Author

MoojMidge added a commit to MoojMidge/plugin.video.youtube that referenced this issue Sep 3, 2024
@MoojMidge MoojMidge mentioned this issue Sep 9, 2024
@Nanomani
Copy link

Nanomani commented Sep 10, 2024

@MoojMidge
Your update 7.1.0 beta1 fix this issue.
When à video is launch from Widget all works fine now.
Thanks a lot for your hard works to make this addon always better.

@C-O-D
Copy link

C-O-D commented Sep 10, 2024

I don't want to be too hasty just yet, but I think a new life has begun 🙏

@MoojMidge
Copy link
Collaborator Author

Keep an eye on things, and if you see it happen again try and get a log.

A regular log will do from the time that it happens, but if you can reproduce it a debug log will be better.

@MoojMidge MoojMidge mentioned this issue Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants