Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Download button #35

Merged
merged 8 commits into from
Mar 17, 2023
Merged

Conversation

RoneoOrg
Copy link
Contributor

Fixes: #27

Successfully tested locally and deployed.

The quality of this PR could be improved though:

  • provide a setting to make the Download button optional
  • cleaner code and comments etc

I won't spend too much time on this though, as several PR a pending, I'll wait to see which branches get merged first

@sonarcloud
Copy link

sonarcloud bot commented Sep 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@anvithks
Copy link
Owner

@RoneoOrg Would it be possible for you to remove all the other code and just add the download button?
Let me know if you have the time.

@sonarcloud
Copy link

sonarcloud bot commented Mar 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Owner

@anvithks anvithks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
@RoneoOrg thanks for this PR.
I have updated the code to retain only the code changes needed for the download button.

@anvithks anvithks merged commit bc77fed into anvithks:master Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide option to allow users to download the PDF file
2 participants