Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CDN instead of including the library files #2

Closed
anvithks opened this issue Sep 9, 2020 · 0 comments · Fixed by #19
Closed

Use CDN instead of including the library files #2

anvithks opened this issue Sep 9, 2020 · 0 comments · Fixed by #19
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@anvithks
Copy link
Owner

anvithks commented Sep 9, 2020 •
edited
Loading

Is your feature request related to a problem? Please describe.
No.

Describe the solution you'd like
At the moment the shortcode requires the user to include the library files locally. This will be a maintenance problem as the library will have to be updated everytime there is a new release.

Describe alternatives you've considered
Ideally the library can be included using a CDN. If not available then consider other projects / libraries that include PDF.js and provide a CDN.

Additional context

Explore the option of making the source of the PDF.js library configurable.
Refer this
@anvithks anvithks added enhancement New feature or request good first issue Good for newcomers labels Sep 9, 2020
ericswpark added a commit to ericswpark/hugo-embed-pdf-shortcode that referenced this issue Jul 2, 2021
@ericswpark
Use CDN to load PDF.js library
9123c31 
Fixes anvithks#18 and anvithks#2
@ericswpark ericswpark mentioned this issue Jul 2, 2021
Merged
anvithks added a commit that referenced this issue Mar 15, 2023
@ericswpark @anvithks
Load PDF.js library from CDN (#19)
b882387 
* Use CDN to load PDF.js library

Fixes #18 and #2

* README: update URLs to https

* README: use relative links for image

* Updated the Pdf.js version

---------

Co-authored-by: Anvith KS <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Load PDF.js library from CDN ericswpark/hugo-embed-pdf-shortcode
1 participant
@anvithks