-
-
Notifications
You must be signed in to change notification settings - Fork 23.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: number of languages param for top langs card #445
Conversation
Codecov Report
@@ Coverage Diff @@
## master #445 +/- ##
==========================================
+ Coverage 93.91% 93.92% +0.01%
==========================================
Files 17 17
Lines 526 527 +1
Branches 143 144 +1
==========================================
+ Hits 494 495 +1
Misses 28 28
Partials 4 4
Continue to review full report at Codecov.
|
Update: there seems to be an issue with the bottom padding being too short for 1 lang and too tall for 10 langs, I'll see if I can fix it. |
Ok, it looks much better now: https://benjamins-readme-stats.vercel.app/api/top-langs/?username=scitronboy&layout=compact&theme=gruvbox&num_langs=10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @scitronboy this looks good, requested a minor change please look into it :) |
Ok, done. I clamped to the number 1, 10 with a default of 5. I have not changed the padding as Aryan suggested as it's the compact theme and I believe changing the padding would make it unnecessarily non-compact. |
Thanks for the PR @scitronboy |
Simply allows a user to specify how many languages to show on the top-langs card, between 1 and 10. Default is still 5.
Example here: https://benjamins-readme-stats-bt29bovd9.vercel.app/api/top-langs/?username=scitronboy&layout=compact&theme=gruvbox&num_langs=10
Let me know if I need to add anything else to the PR.