-
-
Notifications
You must be signed in to change notification settings - Fork 23.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add everforest themes #3060
base: master
Are you sure you want to change the base?
Add everforest themes #3060
Conversation
@marcfyk is attempting to deploy a commit to the github readme stats Team on Vercel. A member of the Team first needs to authorize it. |
Automated Theme PreviewHi, thanks for the theme contribution. Please read our theme contribution guidelines. Warning Keep in mind that we already have a vast collection of different themes. To keep their number manageable, we began to add only themes supported by the community. Your pull request with theme addition will be merged once we get enough positive feedback from the community in the form of thumbs up (see #1935). Remember that you can also support themes of other contributors that you liked to speed up their merge. Note Also, note that if this theme is exclusively for your personal use, then instead of adding it to our theme collection, you can use card customization options. ✔️ Theme PR does adhere to our guidelines. Test results
Result: ✔️ All themes are valid. DetailsEverforest_dark_medium theme previewtitle_color: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some themes are invalid. See the Automated Theme Preview comment above for more information.
Removed light and hard/soft contrast variants due to failing WCAG 2.0 level AA constrast ration test |
@marcfyk based on the number of likes your theme has been selected to be merged 🎉! I gave it my approval if another collaborator also approves it it will be merged into the main branch 👍🏻. Thanks for your contribution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marcfyk based on the number of likes your theme has been selected to be merged 🎉! I gave it my approval if another collaborator also approves it it will be merged into the main branch 👍🏻. Thanks for your contribution.
@rickstaa As i wrote there #1256 (review) some time ago, i think we need to come up with more precise criteria in order to consider that a pull request has been supported by the community. I mean set a specific number of positive ratings that it must score. Since now our requirements for the presence of community support are very vague. If you look at our Top Issues Dashboard, you can see that issues and pull requests that are really interesting to the community can score a hundred or at least 10-15 positive ratings. I would stop at 10-15, after that I would definitely display this requirement in the documentation. What do you think about that? How many positive ratings should receive issue or pull request in order to be considered as community-supported in your opinion?
I designed the Top Issues Dashboard with the intention of providing collaborators with a clear overview of the most pressing concerns: both bug reports and feature requests that have garnered substantial user support. At this juncture, I have refrained from establishing a fixed threshold of positive ratings requisite for addressing a bug or considering a feature request. The determination of this threshold hinges on the intricacy of the issue at hand and the nature of the proposed feature within a pull request. However, for themes that involve direct pull requests, we might contemplate setting a pragmatic limit of 10 positive ratings. This adjustment could be documented in the README for enhanced transparency and guidance. 🤔 Feel free to choose the limit you think is sufficient without cluttering the themes database too much 👍🏻. |
I have opened #3179 and #3180 pull requests which adds clarification into CONTRIBUTING.md and themes preview workflow comment about how many thumbs up we expect to see before making decision about merging themes PRs. |
Add dark and light variants of the theme