-
-
Notifications
You must be signed in to change notification settings - Fork 23.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Stats card: Show merged PRs count and percentage #3003
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3003 +/- ##
==========================================
+ Coverage 97.62% 97.66% +0.04%
==========================================
Files 24 24
Lines 5343 5440 +97
Branches 466 469 +3
==========================================
+ Hits 5216 5313 +97
Misses 125 125
Partials 2 2
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rickstaa I committed an alternate icon for "Merged PRs Percentage" stat. Let me know which of them better on your opinion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the naming, I think this pull request is clean 🚀! Feel free to merge it if you want.
readme.md
Outdated
@@ -156,10 +156,10 @@ You can pass a query parameter `&hide=` to hide any specific stats with comma-se | |||
|
|||
You can pass a query parameter `&show=` to show any specific additional stats with comma-separated values. | |||
|
|||
> Options: `&show=reviews,discussions_started,discussions_answered` | |||
> Options: `&show=reviews,discussions_started,discussions_answered,prs_merged,merged_prs_percentage` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe for consistency, we can call it prs_merged, prs_merged_percentage
. I am, however, also good with your current names if you think they are more apparent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have update the code following your suggestion. Maybe it's better, but it hard for me to judge since i'm not english native speaker.
…a#3003) * Feature: Stats card: Show merged PRs count and percentage * dev * dev * renames
…a#3003) * Feature: Stats card: Show merged PRs count and percentage * dev * dev * renames
…a#3003) * Feature: Stats card: Show merged PRs count and percentage * dev * dev * renames
…a#3003) * Feature: Stats card: Show merged PRs count and percentage * dev * dev * renames
…a#3003) * Feature: Stats card: Show merged PRs count and percentage * dev * dev * renames
This pull request adds ability to show count and percentage of merged PRs on stats card using
&show=
query option.I'm not sure about merged PRs percentage icon, what do you think @rickstaa?