Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence vscode type error in chunkArray function #2965

Merged
merged 1 commit into from
Jul 23, 2023

Conversation

qwerty541
Copy link
Collaborator

Currently we are unable to fix this error since we need to set type for second argument of .reduce() function like [] as Array<Array<T>>. Otherwise it was set never[] by default. Can be fixed after migration on typescript.

@qwerty541 qwerty541 requested a review from rickstaa July 22, 2023 18:18
@vercel
Copy link

vercel bot commented Jul 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
github-readme-stats ✅ Ready (Inspect) Visit Preview Jul 22, 2023 6:18pm

@codecov
Copy link

codecov bot commented Jul 22, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b56689b) 97.62% compared to head (45046cc) 97.62%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2965   +/-   ##
=======================================
  Coverage   97.62%   97.62%           
=======================================
  Files          24       24           
  Lines        5182     5184    +2     
  Branches      460      460           
=======================================
+ Hits         5059     5061    +2     
  Misses        122      122           
  Partials        1        1           
Impacted Files Coverage Δ
src/common/utils.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rickstaa rickstaa merged commit 16c6caa into master Jul 23, 2023
@rickstaa rickstaa deleted the silence_vscode_type_error_in_chunkArray_function branch July 23, 2023 10:24
J00MZ pushed a commit to J00MZ/github-readme-stats that referenced this pull request Jul 23, 2023
devantler pushed a commit to devantler/github-readme-stats that referenced this pull request Sep 24, 2023
ABA2396 pushed a commit to ABA2396/github-readme-stats that referenced this pull request Dec 22, 2023
ABA2396 pushed a commit to ABA2396/github-readme-stats that referenced this pull request Dec 22, 2023
setdebarr pushed a commit to setdebarr/github-readme-stats that referenced this pull request Jan 12, 2024
jacobbexten pushed a commit to jacobbexten/github-readme-stats that referenced this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants