Skip to content

Docs: improve quick align tip section #2865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 22, 2023

Conversation

qwerty541
Copy link
Collaborator

No description provided.

@qwerty541 qwerty541 requested a review from rickstaa June 21, 2023 05:16
@vercel
Copy link

vercel bot commented Jun 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
github-readme-stats ✅ Ready (Inspect) Visit Preview Jun 22, 2023 4:16am

@github-actions github-actions bot added the documentation Improvements or additions to documentation. label Jun 21, 2023
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2642fc5) 97.72% compared to head (ab97ba0) 97.72%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2865   +/-   ##
=======================================
  Coverage   97.72%   97.72%           
=======================================
  Files          24       24           
  Lines        5094     5094           
  Branches      452      452           
=======================================
  Hits         4978     4978           
  Misses        115      115           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@qwerty541 qwerty541 marked this pull request as ready for review June 21, 2023 05:17
@rickstaa
Copy link
Collaborator

@qwerty541 I think the location of this item is correct, as it is a tip for all cards. I would change the right card to another card, like the stats card.

@rickstaa
Copy link
Collaborator

rickstaa commented Jun 21, 2023

<a href="https://github.com/anuraghazra/github-readme-stats">
  <img height=200 align="center" src="https://github-readme-stats.vercel.app/api?username=anuraghazra&card_width=400" />
</a>
<a href="https://github.com/anuraghazra/convoychat">
  <img height=200 align="center" src="https://github-readme-stats.vercel.app/api/top-langs?username=anuraghazra&layout=compact&langs_count=8&card_width=400" />
</a>
<a href="https://github.com/anuraghazra/github-readme-stats">
  <img align="center" src="https://github-readme-stats.vercel.app/api/pin?username=anuraghazra&repo=github-readme-stats" />
</a>
</a>
<a href="https://github.com/anuraghazra/github-readme-stats">
  <img align="center" src="https://github-readme-stats.vercel.app/api/pin?username=anuraghazra&repo=github-readme-stats" />
</a>

Copy link
Collaborator Author

@qwerty541 qwerty541 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qwerty541 I think the location of this item is correct, as it is a tip for all cards. I would change the right card to another card, like the stats card.

@rickstaa Yes, you are right, this tip can be used for all card. I have updated the code by adding additional example with stats and languages cards and by adding opt-in example preview. Please check it. I decided to guide people with both examples because align method is different, you need to specify height and width manually for stats and languages cards to set them at center.

изображение

@qwerty541 qwerty541 changed the title Docs: move extra pins align tip into correct section Docs: improve quick align tip section Jun 22, 2023
@rickstaa
Copy link
Collaborator

@qwerty541 I think the location of this item is correct, as it is a tip for all cards. I would change the right card to another card, like the stats card.

@rickstaa Yes, you are right, this tip can be used for all card. I have updated the code by adding additional example with stats and languages cards and by adding opt-in example preview. Please check it. I decided to guide people with both examples because align method is different, you need to specify height and width manually for stats and languages cards to set them at center.

изображение

Amazing thanks!

@rickstaa rickstaa merged commit f282ce4 into master Jun 22, 2023
@rickstaa rickstaa deleted the docs_move_pins_align_tip_into_correct_section branch June 22, 2023 08:29
HackingGate pushed a commit to HackingGate/github-readme-stats that referenced this pull request Jun 25, 2023
* Docs: move extra pins align tip into correct section

* dev

* dev

* dev

* dev

* dev

* dev
J00MZ pushed a commit to J00MZ/github-readme-stats that referenced this pull request Jul 23, 2023
* Docs: move extra pins align tip into correct section

* dev

* dev

* dev

* dev

* dev

* dev
devantler pushed a commit to devantler/github-readme-stats that referenced this pull request Sep 24, 2023
* Docs: move extra pins align tip into correct section

* dev

* dev

* dev

* dev

* dev

* dev
setdebarr pushed a commit to setdebarr/github-readme-stats that referenced this pull request Jan 12, 2024
* Docs: move extra pins align tip into correct section

* dev

* dev

* dev

* dev

* dev

* dev
jacobbexten pushed a commit to jacobbexten/github-readme-stats that referenced this pull request Nov 6, 2024
* Docs: move extra pins align tip into correct section

* dev

* dev

* dev

* dev

* dev

* dev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants