Remove several redundant number -> string -> number conversions #2856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2856 +/- ##
=======================================
Coverage 97.71% 97.71%
=======================================
Files 24 24
Lines 5076 5076
Branches 451 451
=======================================
Hits 4960 4960
Misses 115 115
Partials 1 1
☔ View full report in Codecov by Sentry. |
rickstaa
reviewed
Jun 19, 2023
| @@ -204,7 +204,7 @@ const renderWakatimeCard = (stats = {}, options = { hide: [] }) => { | |||
|
|
|||
| const lheight = parseInt(String(line_height), 10); | |||
|
|
|||
| const langsCount = clampValue(parseInt(String(langs_count)), 1, langs_count); | |||
| const langsCount = clampValue(langs_count, 1, langs_count); | |||
There was a problem hiding this comment.
@qwerty541, good catch. Here I found another one 👍🏻.
…move_redundant_conversion
qwerty541
changed the title
HackingGate
pushed a commit
to HackingGate/github-readme-stats
that referenced
this pull request
Jun 25, 2023
…aghazra#2856) * Top langs card: remove redundant number -> string -> number conversion * refactor(waka): remove redundant praseInt --------- Co-authored-by: rickstaa <[email protected]>
devantler
pushed a commit
to devantler/github-readme-stats
that referenced
this pull request
Sep 24, 2023
…aghazra#2856) * Top langs card: remove redundant number -> string -> number conversion * refactor(waka): remove redundant praseInt --------- Co-authored-by: rickstaa <[email protected]>
setdebarr
pushed a commit
to setdebarr/github-readme-stats
that referenced
this pull request
Jan 12, 2024
…aghazra#2856) * Top langs card: remove redundant number -> string -> number conversion * refactor(waka): remove redundant praseInt --------- Co-authored-by: rickstaa <[email protected]>
jacobbexten
pushed a commit
to jacobbexten/github-readme-stats
that referenced
this pull request
Nov 6, 2024
…aghazra#2856) * Top langs card: remove redundant number -> string -> number conversion * refactor(waka): remove redundant praseInt --------- Co-authored-by: rickstaa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.