Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add include_orgs card variable #2277

Closed
wants to merge 1 commit into from
Closed

feat: add include_orgs card variable #2277

wants to merge 1 commit into from

Conversation

rickstaa
Copy link
Collaborator

@rickstaa rickstaa commented Nov 21, 2022 •
edited
Loading

This pull request adds experimental Organization support. Users can include stats from Organization repositories to which they are collaborators using the include_orgs card argument. Please be aware that because of #1852, only the first 100 repositories are used. Including organization, stats might therefore skew your results.

TODOs

  • Add a test that checks whether Axios receives the right request query. I tried to google how this is done but could not yet find a good solution. @anuraghazra, do you know how we can implement such a test?

@vercel
Copy link

vercel bot commented Nov 21, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
github-readme-stats ✅ Ready (Inspect) Visit Preview Nov 22, 2022 at 8:51AM (UTC)

@codecov
Copy link

codecov bot commented Nov 21, 2022 •
edited
Loading

Codecov Report

Base: 96.79% // Head: 96.81% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (06aee4f) compared to base (9eb0c3c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2277      +/-   ##
==========================================
+ Coverage   96.79%   96.81%   +0.02%     
==========================================
  Files          22       22              
  Lines        3835     3862      +27     
  Branches      328      331       +3     
==========================================
+ Hits         3712     3739      +27     
  Misses        121      121              
  Partials        2        2
Impacted Files Coverage Δ
api/index.js 96.03% <100.00%> (+0.07%) ⬆️
api/top-langs.js 95.34% <100.00%> (+0.11%) ⬆️
src/common/utils.js 100.00% <100.00%> (ø)
src/fetchers/stats-fetcher.js 91.46% <100.00%> (+0.46%) ⬆️
src/fetchers/top-languages-fetcher.js 87.75% <100.00%> (+0.70%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rickstaa
Copy link
Collaborator Author

@anuraghazra Are there any problems with merging this PRs other than the results being skewed because of #1852?

This was referenced Nov 21, 2022
Open
Draft
@rickstaa
Copy link
Collaborator Author

@anuraghazra Maybe we should add a note about #1852 in the readme when merging this PR.

@rickstaa @developStorm
feat: add include_orgs card variable
06aee4f 
This pull request adds experimental Organization support. Users can
include stats from Organization repositories to which they are
collaborators using the `include_orgs` card argument. Please be aware
that because of #1852, only the first 100 repositories are used.
Including organization, stats might therefore skew your results.

Co-authored-by: Raymond Nook <[email protected]>
This was referenced Jan 3, 2023
Closed
Closed
@github-actions github-actions bot mentioned this pull request Jan 4, 2023
Open
@rickstaa rickstaa force-pushed the master branch 2 times, most recently from 86aafe8 to 8bc69e7 Compare January 21, 2023 16:47
@rickstaa
Copy link
Collaborator Author

Replaced by #2459 since I don't mind giving people more control.

@rickstaa rickstaa closed this Jan 24, 2023
@rickstaa rickstaa mentioned this pull request Jan 24, 2023
Open
@rickstaa rickstaa deleted the master_orgs branch March 5, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@developStorm developStorm developStorm approved these changes

@j-i-l j-i-l j-i-l approved these changes

@anuraghazra anuraghazra Awaiting requested review from anuraghazra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rickstaa @j-i-l @developStorm