Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fetch top lang in each repository #204

Merged
merged 1 commit into from
Jul 26, 2020

Conversation

SSARCandy
Copy link
Contributor

  • Fetch top language in each repo by adding orderBy: {field: SIZE, direction: DESC} constrain.
  • Using the most recent 100 repositories for calculation.

@codecov
Copy link

codecov bot commented Jul 26, 2020

Codecov Report

Merging #204 into master will increase coverage by 0.30%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #204      +/-   ##
==========================================
+ Coverage   94.76%   95.07%   +0.30%     
==========================================
  Files          15       15              
  Lines         382      406      +24     
  Branches      115      120       +5     
==========================================
+ Hits          362      386      +24     
  Misses         16       16              
  Partials        4        4              
Impacted Files Coverage Δ
src/fetchTopLanguages.js 100.00% <ø> (ø)
api/top-langs.js 100.00% <0.00%> (ø)
src/renderTopLanguages.js 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bdcf3d...d929e8b. Read the comment docs.

@anuraghazra
Copy link
Owner

Thanks @SSARCandy for the PR, LGTM!

@anuraghazra anuraghazra merged commit 68198d8 into anuraghazra:master Jul 26, 2020
@NikhilCodes
Copy link

NikhilCodes commented Jul 29, 2020

Dart and javascript has disappeared, again.

@anuraghazra
Copy link
Owner

@NikhilCodes please read the comment I mentioned here, #136 (comment) and also check out the latest PR #240

I've mentioned some important points in #136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants