Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Display Wakatime Editor, Category and OS Stats #1202

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

Morphclue
Copy link
Contributor

@Morphclue Morphclue commented Jul 22, 2021

Description

I've added a new query-parameter to display used editors. categories and os in wakatime. This feature was also requested in #1107. To do that I have refactored renderWakatimeCard to render the corresponding card depending on the graph query-parameter.

I also wanted to rename the langs_count into unit_count or item_count, but i think this might break earlier versions. That's why langs_count will also change the displayed editor-count.

Code

  • Added graph param in wakatime.js and wakatime-card.js
  • Adjusted README

Types of changes

  • Enhancement
  • Refactor

Reference

image
image
image

@vercel
Copy link

vercel bot commented Jul 22, 2021

@distrustME is attempting to deploy a commit to the github readme stats Team on Vercel.

A member of the Team first needs to authorize it.

@Morphclue Morphclue changed the title feature: Display Wakatime Editor Stats feature: Display Wakatime Editor, Category and OS Stats Jul 23, 2021
@codecov
Copy link

codecov bot commented Sep 3, 2021

Codecov Report

Base: 96.65% // Head: 96.58% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (2cdd84a) compared to base (1d10912).
Patch coverage: 92.10% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1202      +/-   ##
==========================================
- Coverage   96.65%   96.58%   -0.07%     
==========================================
  Files          22       22              
  Lines        3797     3809      +12     
  Branches      323      326       +3     
==========================================
+ Hits         3670     3679       +9     
- Misses        125      128       +3     
  Partials        2        2              
Impacted Files Coverage Δ
src/cards/wakatime-card.js 99.13% <92.10%> (-0.87%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rickstaa rickstaa added wakatime-card Issues related to the wakatime card. enhancement New feature or request. labels May 3, 2022
# Conflicts:
#	readme.md
#	src/cards/wakatime-card.js
@Morphclue
Copy link
Contributor Author

Morphclue commented Jul 10, 2022

The only test that is failing and preventing a successful build is tests/card.test.js.
This is related to #1851.

@rickstaa rickstaa force-pushed the master branch 2 times, most recently from 86aafe8 to 8bc69e7 Compare January 21, 2023 16:47
@rickstaa rickstaa added the ⭐ top pull request Top pull request. label May 9, 2023
@luftaquila
Copy link

luftaquila commented Dec 9, 2024

Hello, thank you for the great PR. Is there any reason that this PR is not merged yet? It looks like there is no conflicts to master despite it is quite old.

Copy link

vercel bot commented Dec 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
github-readme-stats ✅ Ready (Inspect) Visit Preview Dec 9, 2024 5:47pm

@github-actions github-actions bot added the documentation Improvements or additions to documentation. label Dec 9, 2024
@Morphclue
Copy link
Contributor Author

@rickstaa Are there any plans to merge this PR in the near future (not in another three and half a year pls)? I'm willing to further customize my code, document or write more tests if needed.

@luftaquila
Copy link

I'm looking forward to this PR's merge, but it seems the repo has not merged any PRs in the past few months. I'd better host my own with this PR. Thank you for your work!

@luftaquila
Copy link

image

I successfully deployed my own instance with this PR.

Actually, I had to update languageColors.json to get colors correctly. (luftaquila@d964837)

Thank you for your great work again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation. enhancement New feature or request. ⭐ top pull request Top pull request. wakatime-card Issues related to the wakatime card.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants