Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showing number of commits from last 1 year instead of the current year #1053

Open
Showrin opened this issue May 11, 2021 · 11 comments · May be fixed by #2107
Open

Showing number of commits from last 1 year instead of the current year #1053

Showrin opened this issue May 11, 2021 · 11 comments · May be fixed by #2107
Labels
bug Something isn't working. hacktoberfest hacktoberfest-accepted help wanted Extra attention is needed. high-priority High priority issue or PR. ⭐ top bug Top bug. stats-card Feature, Enhancement, Fixes related to stats the stats card.

Comments

@Showrin
Copy link

Showrin commented May 11, 2021

Describe the bug
The card is showing the number of commits from the last 1 year. Like: Total Commits (2021): 1.5k. As it's saying 2021 in the bracket, then shouldn't it either show the commits (620) from the year 2021 or show Last 1 year instead of 2021?

Expected behavior
It should show the commit from the current year or change Total Commits (2021) to Total Commits (Last 1 year).

Screenshots / Live demo link (paste the github-readme-stats link as markdown image)
Screenshot 2021-05-11 at 1 22 03 PM

@florianbussmann
Copy link
Contributor

Yes, the expected behavior is to show the contributions from last year and I support your opinion that this is misleading
#211 (comment)

@rickstaa
Copy link
Collaborator

rickstaa commented Jun 14, 2022

As pointed out in #1815 the current behaviour is misleading and should be fixed. As pointed out by @hashfx the card should have an option to choose between year-wise, current year or total. Further, the active mode should be displayed on the card. I am currently very short on time, so I can not implement this myself but feel free to create a PR for this feature to review. I added the label since I think this is an important bug that should be fixed.

@rickstaa rickstaa removed the popular label Sep 22, 2022
@rickstaa rickstaa added help wanted Extra attention is needed. hacktoberfest labels Oct 1, 2022
@asifurrahaman754
Copy link

Hi is this sovled?

@adi-uchiha
Copy link
Contributor

hey there, I want to work on this.
@rickstaa Can you please assist me

@rickstaa
Copy link
Collaborator

rickstaa commented Oct 2, 2022

@adi-uchiha This is still an issue. It would be great if this behaviour is improved. 💪🏻 I assigned you to this issue since I already assigned @asifurrahaman754 to several issues. Feel free to contact me if you have any questions.

@rickstaa rickstaa added the high-priority High priority issue or PR. label Oct 10, 2022
rickstaa added a commit to vzsky/github-readme-stats that referenced this issue Oct 16, 2022
This commit makes sure the last year label is shown when
`include_all_commits` or `year` is not provided. See anuraghazra#1053 for more
information.
@rickstaa
Copy link
Collaborator

@adi-uchiha, while checking #2107, I noticed that #1053 and #764 are related and that #1053 should best be solved in #2107 since this PR adds a lot of new code. Merging #1053 will therefore solve this issue. Sorry for the confusion.

@rickstaa
Copy link
Collaborator

This issue is solved when #2107 is merged.

@rickstaa
Copy link
Collaborator

Related to #764.

@alihamza1221
Copy link

is this issue solved ? If not can you assest me I am quite interested on working this issue

@qwerty541
Copy link
Collaborator

is this issue solved ? If not can you assest me I am quite interested on working this issue

Hey, @alihamza1221! Thanks for your interest to the our project and considering contributions. Looks like we already have pull request #2107 which will resolve this issue. Feel free to choose another issue that you are interested to work on.

@muskanyadav1134
Copy link

Can you please assign this to me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working. hacktoberfest hacktoberfest-accepted help wanted Extra attention is needed. high-priority High priority issue or PR. ⭐ top bug Top bug. stats-card Feature, Enhancement, Fixes related to stats the stats card.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants