Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(export): export corner bug #856

Merged
merged 6 commits into from
Dec 3, 2021
Merged

fix(export): export corner bug #856

merged 6 commits into from
Dec 3, 2021

Conversation

YardWill
Copy link
Member

@YardWill YardWill commented Dec 2, 2021

👀 PR includes

✨ Feature

  • New feature

🎨 Enhance

  • Code style optimization
  • Refactoring
  • Change the UI
  • Improve the performance
  • Type optimization

🐛 Bugfix

🔧 Chore

  • Test case
  • Docs / demos update
  • CI / workflow
  • Release version
  • Other ()

📝 Description

🖼️ Screenshot

Before After

🔗 Related issue link

🔍 Self Check before Merge

  • Add or update relevant Docs.
  • Add or update relevant Demos.
  • Add or update relevant TypeScript definitions.

@github-actions github-actions bot added the pr(fix) bug fix label Dec 2, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2021

🎊 PR Preview has been successfully built and deployed to https://s2-preview-pr-856.surge.sh

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2021

Size Change: +165 B (0%)

Total Size: 185 kB

Filename Size Change
./packages/s2-core/dist/index.min.js 113 kB +165 B (0%)
ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/style.min.css 356 B
./packages/s2-react/dist/index.min.js 68.5 kB
./packages/s2-react/dist/style.min.css 3.1 kB

compressed-size-action

@lgtm-com
Copy link

lgtm-com bot commented Dec 2, 2021

This pull request fixes 2 alerts when merging 2963b78 into 025ec55 - view on LGTM.com

fixed alerts:

  • 2 for Unused variable, import, function or class

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2021

你好, @YardWill CI 执行失败, 请点击 [Details] 按钮查看, 并根据日志修复。

Hello, @YardWill CI run failed, please click the [Details] button try to fixed it.

@github-actions github-actions bot added the 🚨 test failed 单元测试挂了 label Dec 2, 2021
@lgtm-com
Copy link

lgtm-com bot commented Dec 3, 2021

This pull request fixes 2 alerts when merging 6d06e90 into 025ec55 - view on LGTM.com

fixed alerts:

  • 2 for Unused variable, import, function or class

@codecov
Copy link

codecov bot commented Dec 3, 2021

Codecov Report

Merging #856 (5fff592) into master (114e7fc) will increase coverage by 0.01%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #856      +/-   ##
==========================================
+ Coverage   71.41%   71.42%   +0.01%     
==========================================
  Files         168      168              
  Lines       11734    11753      +19     
  Branches     2743     2747       +4     
==========================================
+ Hits         8380     8395      +15     
- Misses       2206     2207       +1     
- Partials     1148     1151       +3     
Impacted Files Coverage Δ
packages/s2-core/src/utils/export/index.ts 68.57% <92.85%> (+1.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 114e7fc...5fff592. Read the comment docs.

@github-actions github-actions bot removed the 🚨 test failed 单元测试挂了 label Dec 3, 2021
packages/s2-core/src/utils/export/index.ts Outdated Show resolved Hide resolved
packages/s2-core/src/utils/export/index.ts Outdated Show resolved Hide resolved
packages/s2-core/src/utils/export/index.ts Outdated Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Dec 3, 2021

This pull request fixes 2 alerts when merging 8defa4a into 114e7fc - view on LGTM.com

fixed alerts:

  • 2 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Dec 3, 2021

This pull request fixes 2 alerts when merging 5fff592 into 114e7fc - view on LGTM.com

fixed alerts:

  • 2 for Unused variable, import, function or class

@lijinke666 lijinke666 merged commit ccbc851 into master Dec 3, 2021
@lijinke666 lijinke666 deleted the yard/1203/export branch December 3, 2021 07:59
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2021

🎉 This PR is included in version @antv/s2-v1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

wjgogogo pushed a commit that referenced this pull request Oct 25, 2023
* fix: export corner bug

* fix: add test

* fix: test

* fix: pr problem

* fix: pr problem

Co-authored-by: wengyidong.wyd <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛导出组件功能,导出文件表头缺失
2 participants