Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: 修复单测卡死的问题 #3084

Merged
merged 3 commits into from
Jan 23, 2025
Merged

test: 修复单测卡死的问题 #3084

merged 3 commits into from
Jan 23, 2025

Conversation

lijinke666
Copy link
Member

👀 PR includes

✨ Feature

  • New feature

🎨 Enhance

  • Code style optimization
  • Refactoring
  • Change the UI
  • Improve the performance
  • Type optimization

🐛 Bugfix

  • Solve the issue and close #0

🔧 Chore

  • Test case
  • Docs / demos update
  • CI / workflow
  • Release version
  • Other ()

📝 Description

🖼️ Screenshot

Before After

🔗 Related issue link

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

Copy link
Contributor

你好 @lijinke666,非常感谢你的贡献.
为了让代码更健壮, 请根据 贡献指南 补充相应单元测试 (文档改动或其他特殊场景除外), 如果有 API 改动, 请修改 相应的文档.
同时请检查 linttest 相关 CI 是否通过, 如果失败, 请点击 [Details] 按钮查看, 并根据日志修复.

Hello, @lijinke666, Thanks for your contribution. In order to make the code more robust, please add the corresponding unit tests, and update the docs if there are API changes.
At the same time, please check whether the CI related to lint and test passes. If the CI fails, please click [Details] button to check and repair according to the log.

@github-actions github-actions bot added the next 2.0-next 版本的问题 label Jan 23, 2025
@github-actions github-actions bot requested a review from wjgogogo January 23, 2025 02:59
@github-actions github-actions bot added the pr(test) test case label Jan 23, 2025
Copy link

概要

此PR主要涉及测试配置和依赖项的更新。具体来说,更新了Jest配置以忽略特定路径,并增加了测试超时时间。此外,还升级了一些依赖包版本。

变更

文件 概要
jest.config.base.js 更新了Jest配置,增加了testPathIgnorePatterns以忽略benchmark路径,并将testTimeout从30000毫秒增加到100000毫秒。
package.json, pnpm-lock.yaml 升级了@swc/core@swc/jest等依赖包的版本。
packages/s2-core/tests/unit/facet/pivot-facet-spec.ts 修改了测试用例,期望backgroundGroup.children的长度从1变为2。
🪧 Tips 如需进一步帮助,请在评论中描述您的问题,并@petercat-assistant与我开始对话。

@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.80%. Comparing base (ecdc9c8) to head (229981e).
Report is 605 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3084      +/-   ##
==========================================
+ Coverage   75.77%   79.80%   +4.03%     
==========================================
  Files         257      211      -46     
  Lines       11994    11622     -372     
  Branches     2464     2617     +153     
==========================================
+ Hits         9088     9275     +187     
+ Misses       1398      782     -616     
- Partials     1508     1565      +57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jan 23, 2025

Size Change: 0 B

Total Size: 619 kB

ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/s2-extends.min.js 154 kB
./packages/s2-core/dist/s2.min.css 581 B
./packages/s2-core/dist/s2.min.js 257 kB
./packages/s2-react-components/dist/s2-react-components.min.css 2.55 kB
./packages/s2-react-components/dist/s2-react-components.min.js 124 kB
./packages/s2-react/dist/s2-react.min.css 1.74 kB
./packages/s2-react/dist/s2-react.min.js 38.3 kB
./packages/s2-vue/dist/s2-vue.min.css 2.05 kB
./packages/s2-vue/dist/s2-vue.min.js 38.3 kB

compressed-size-action

Copy link
Contributor

github-actions bot commented Jan 23, 2025

你好, @lijinke666 CI 执行失败, 请点击 [Details] 按钮查看, 并根据日志修复。

Hello, @lijinke666 CI run failed, please click the [Details] button for detailed log information and fix it.

@github-actions github-actions bot added the 🚨 test failed 单元测试挂了 label Jan 23, 2025
@github-actions github-actions bot added 🚨 test failed 单元测试挂了 and removed 🚨 test failed 单元测试挂了 labels Jan 23, 2025
@github-actions github-actions bot removed the 🚨 test failed 单元测试挂了 label Jan 23, 2025
@lijinke666 lijinke666 changed the title test: 测试单测 test: 修复单测卡死的问题 Jan 23, 2025
@lijinke666 lijinke666 merged commit 9b2863c into next Jan 23, 2025
11 checks passed
@lijinke666 lijinke666 deleted the chore-test branch January 23, 2025 03:36
@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-v2.1.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next 2.0-next 版本的问题 pr(test) test case released on @latest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants