Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复组件层更新后 G 的 Group 图层累加的问题 #3081

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

lijinke666
Copy link
Member

👀 PR includes

✨ Feature

  • New feature

🎨 Enhance

  • Code style optimization
  • Refactoring
  • Change the UI
  • Improve the performance
  • Type optimization

🐛 Bugfix

🔧 Chore

  • Test case
  • Docs / demos update
  • CI / workflow
  • Release version
  • Other ()

📝 Description

🖼️ Screenshot

Before After

🔗 Related issue link

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

Copy link
Contributor

你好 @lijinke666,非常感谢你的贡献.
为了让代码更健壮, 请根据 贡献指南 补充相应单元测试 (文档改动或其他特殊场景除外), 如果有 API 改动, 请修改 相应的文档.
同时请检查 linttest 相关 CI 是否通过, 如果失败, 请点击 [Details] 按钮查看, 并根据日志修复.

Hello, @lijinke666, Thanks for your contribution. In order to make the code more robust, please add the corresponding unit tests, and update the docs if there are API changes.
At the same time, please check whether the CI related to lint and test passes. If the CI fails, please click [Details] button to check and repair according to the log.

@github-actions github-actions bot added the next 2.0-next 版本的问题 label Jan 17, 2025
@github-actions github-actions bot requested a review from wjgogogo January 17, 2025 03:52
@github-actions github-actions bot added the pr(fix) bug fix label Jan 17, 2025
Copy link

Walkthrough

此PR修复了组件层更新时G的Group累加问题。通过简化clearAllGroup方法,直接移除panelGroupforegroundGroupbackgroundGroup,解决了累加问题,提升了代码的简洁性和可维护性。

Changes

文件 摘要
packages/s2-core/src/facet/base-facet.ts 简化clearAllGroup方法,直接移除panelGroupforegroundGroupbackgroundGroup
packages/s2-core/src/facet/table-facet.ts 调整clearAllGroup方法,直接移除emptyPlaceholderGroup


this.foregroundGroup.removeChildren();
this.backgroundGroup.removeChildren();
this.panelGroup.remove();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change from removeChildren() to remove() will remove the entire group, not just its children. Ensure this is the intended behavior, as it may affect the rendering or structure if the group itself is needed later.

@lijinke666 lijinke666 changed the title fix: 修复组件层更新 G 的 Group 累加的问题 fix: 修复组件层更新后 G 的 Group 图层累加的问题 Jan 17, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.77%. Comparing base (ecdc9c8) to head (0f84cd6).
Report is 599 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3081      +/-   ##
==========================================
  Coverage   75.77%   75.77%              
==========================================
  Files         257       51     -206     
  Lines       11994     1490   -10504     
  Branches     2464      284    -2180     
==========================================
- Hits         9088     1129    -7959     
+ Misses       1398      210    -1188     
+ Partials     1508      151    -1357     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Size Change: -53 B (-0.01%)

Total Size: 619 kB

Filename Size Change
./packages/s2-core/dist/s2.min.js 257 kB -53 B (-0.02%)
ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/s2-extends.min.js 154 kB
./packages/s2-core/dist/s2.min.css 581 B
./packages/s2-react-components/dist/s2-react-components.min.css 2.55 kB
./packages/s2-react-components/dist/s2-react-components.min.js 124 kB
./packages/s2-react/dist/s2-react.min.css 1.74 kB
./packages/s2-react/dist/s2-react.min.js 38.3 kB
./packages/s2-vue/dist/s2-vue.min.css 2.05 kB
./packages/s2-vue/dist/s2-vue.min.js 38.3 kB

compressed-size-action

@lijinke666 lijinke666 merged commit c290b08 into next Jan 17, 2025
15 of 16 checks passed
@lijinke666 lijinke666 deleted the fix-destroy-group branch January 17, 2025 04:29
@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-v2.1.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next 2.0-next 版本的问题 pr(fix) bug fix released on @latest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 TableSheet 在滚动时添加数据,然后在搜索过滤的时候,会出现视图异常
3 participants