Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复拖拽列宽后, 默认的自定义列宽失效 close #2910 #2915

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

lijinke666
Copy link
Member

👀 PR includes

🐛 Bugfix

🔧 Chore

  • Test case
  • Docs / demos update
  • CI / workflow
  • Release version
  • Other ()

📝 Description

#2910 的描述, 写的比较详细

🖼️ Screenshot

Before After

🔗 Related issue link

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

Copy link

vercel bot commented Sep 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
antvis-s2 ❌ Failed (Inspect) Sep 30, 2024 7:29am

@github-actions github-actions bot added the pr(fix) bug fix label Sep 30, 2024
@github-actions github-actions bot added the next 2.0-next 版本的问题 label Sep 30, 2024
@@ -823,6 +825,10 @@ describe('Interaction Row Column Resize Tests', () => {
},
});

jest
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

之前 mock 有问题, 没走到多选的链路

Copy link
Contributor

Size Change: +5 B (0%)

Total Size: 329 kB

Filename Size Change
./packages/s2-core/dist/index.min.js 229 kB +5 B (0%)
ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/style.min.css 388 B
./packages/s2-react/dist/index.min.js 70.9 kB
./packages/s2-react/dist/style.min.css 3.88 kB
./packages/s2-vue/dist/index.min.js 22.9 kB
./packages/s2-vue/dist/style.min.css 1.97 kB

compressed-size-action

Copy link
Contributor

你好, @lijinke666 CI 执行失败, 请点击 [Details] 按钮查看, 并根据日志修复。

Hello, @lijinke666 CI run failed, please click the [Details] button for detailed log information and fix it.

@github-actions github-actions bot added 🚨 test failed 单元测试挂了 and removed 🚨 test failed 单元测试挂了 labels Sep 30, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.80%. Comparing base (ecdc9c8) to head (2dd8876).
Report is 441 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2915      +/-   ##
==========================================
+ Coverage   75.77%   80.80%   +5.03%     
==========================================
  Files         257      180      -77     
  Lines       11994    10418    -1576     
  Branches     2464     2361     -103     
==========================================
- Hits         9088     8418     -670     
+ Misses       1398      554     -844     
+ Partials     1508     1446      -62     
Flag Coverage Δ
80.80% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next 2.0-next 版本的问题 pr(fix) bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛明细表在拖拽列宽后,会导致未被拖拽列的已自定义的列宽失效
2 participants