Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typo): Change target attribute from _black to _blank #2823

Merged
merged 1 commit into from
Jul 19, 2024
Merged

fix(typo): Change target attribute from _black to _blank #2823

merged 1 commit into from
Jul 19, 2024

Conversation

leinad59
Copy link
Contributor

πŸ‘€ PR includes

✨ Feature

  • New feature

🎨 Enhance

  • Code style optimization
  • Refactoring
  • Change the UI
  • Improve the performance
  • Type optimization

πŸ› Bugfix

  • Solve the issue and close #0 (no existing issue found)

πŸ”§ Chore

  • Test case
  • Docs / demos update
  • CI / workflow
  • Release version
  • Other ()

πŸ“ Description

This commit addresses the issue where page navigation incorrectly overwrote the content of previously opened tabs. By changing the target attribute of the a-tag from _black to _blank, new pages will now open in a new tab, preventing the overwriting of existing tabs.

πŸ–ΌοΈ Screenshot

Before After
❌ βœ…

πŸ”— Related issue link

πŸ” Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

This commit addresses the issue where page navigation incorrectly overwrote the content of previously opened tabs. By changing the target attribute of the a-tag from _black to _blank, new pages will now open in a new tab, preventing the overwriting of existing tabs.
Copy link

vercel bot commented Jul 18, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
antvis-s2 ❌ Failed (Inspect) Jul 18, 2024 2:04pm

@lijinke666 lijinke666 merged commit c76a510 into antvis:master Jul 19, 2024
11 of 12 checks passed
@leinad59 leinad59 deleted the patch-1 branch July 19, 2024 02:49
lijinke666 pushed a commit that referenced this pull request Jul 26, 2024
This commit addresses the issue where page navigation incorrectly overwrote the content of previously opened tabs. By changing the target attribute of the a-tag from _black to _blank, new pages will now open in a new tab, preventing the overwriting of existing tabs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr(fix) bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants