Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复 showPagination interface 类型 #2157

Closed
wants to merge 1 commit into from

Conversation

qxqzx13
Copy link

@qxqzx13 qxqzx13 commented Apr 8, 2023

fix: 修复 showPagination interface 类型. 对应 issues #2147

@vercel
Copy link

vercel bot commented Apr 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
antvis-s2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 8, 2023 2:44am

@codecov
Copy link

codecov bot commented Apr 8, 2023

Codecov Report

Patch coverage: 78.57% and project coverage change: +0.02 🎉

Comparison is base (1adc25d) 76.48% compared to head (caeb6d8) 76.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2157      +/-   ##
==========================================
+ Coverage   76.48%   76.50%   +0.02%     
==========================================
  Files         240      240              
  Lines       12312    12323      +11     
  Branches     2630     2631       +1     
==========================================
+ Hits         9417     9428      +11     
+ Misses       1377     1376       -1     
- Partials     1518     1519       +1     
Impacted Files Coverage Δ
...nteraction/brush-selection/base-brush-selection.ts 75.76% <70.00%> (+0.42%) ⬆️
...ction/brush-selection/data-cell-brush-selection.ts 87.03% <100.00%> (-0.47%) ⬇️
...interaction/brush-selection/row-brush-selection.ts 85.48% <100.00%> (+1.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lcx-seima
Copy link
Contributor

你这是把现有的函数定义直接改了啊(特别是 onShowSizeChange),不建议 breaking change🤔
shared 里的 interface 在 react/vue 里都会用的

+ onShowSizeChange?: (current: number, pageSize: number) => void;
+ onChange?: (current: number, pageSize: number) => void;

@lcx-seima
Copy link
Contributor

另外,你原 issue 是说 onShowSizeChange 回调的值错了?
看了下 packages/s2-vue/src/components/pagination/index.vue 里,确实是用的第二个参数往外透出呀。

@showSizeChange="(_, size) => $emit('showSizeChange', size)"

看下来,本 pr 里改动更像是个 feat,不是 fix 吧 🤔?

@qxqzx13
Copy link
Author

qxqzx13 commented Apr 18, 2023

另外,你原 issue 是说 onShowSizeChange 回调的值错了? 看了下 packages/s2-vue/src/components/pagination/index.vue 里,确实是用的第二个参数往外透出呀。

@showSizeChange="(_, size) => $emit('showSizeChange', size)"

看下来,本 pr 里改动更像是个 feat,不是 fix 吧 🤔?

我使用的是
s2 1.43.0

s2-react 1.37.1

@lcx-seima
Copy link
Contributor

感谢你的 PR,更多信息可以查看 #2238
这边就先关闭了

@lcx-seima lcx-seima closed this Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr(fix) bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants