-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 修复 showPagination interface 类型 #2157
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2157 +/- ##
==========================================
+ Coverage 76.48% 76.50% +0.02%
==========================================
Files 240 240
Lines 12312 12323 +11
Branches 2630 2631 +1
==========================================
+ Hits 9417 9428 +11
+ Misses 1377 1376 -1
- Partials 1518 1519 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
你这是把现有的函数定义直接改了啊(特别是 onShowSizeChange),不建议 breaking change🤔 + onShowSizeChange?: (current: number, pageSize: number) => void;
+ onChange?: (current: number, pageSize: number) => void; |
另外,你原 issue 是说 onShowSizeChange 回调的值错了?
看下来,本 pr 里改动更像是个 feat,不是 fix 吧 🤔? |
我使用的是 |
感谢你的 PR,更多信息可以查看 #2238 |
fix: 修复 showPagination interface 类型. 对应 issues #2147