复制相关bugfix #2037

serializedowen · 2023-01-09T07:29:44Z

👀 PR includes

✨ Feature

New feature

🎨 Enhance

🐛 Bugfix
fix: 选择datacell不连带选中column cell（会导致选中单个单元格copy时copy整列）
fix: 复制带双引号不再改变原始值
fix: 复制不规则单元格不再报错

🔧 Chore

📝 Description

🖼️ Screenshot

Before	After
❌	✅

🔗 Related issue link

🔍 Self-Check before the merge

Add or update relevant docs.
Add or update relevant demos.
Add or update test case.
Add or update relevant TypeScript definitions.

vercel · 2023-01-09T07:29:48Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
antvis-s2	❌ Failed (Inspect)		Jan 11, 2023 at 11:57AM (UTC)

github-actions · 2023-01-09T07:36:20Z

Size Change: -12 B (0%)

Total Size: 435 kB

Filename	Size	Change
`./packages/s2-core/dist/index.min.js`	171 kB	-12 B (0%)

ℹ️ View Unchanged

Filename	Size
`./packages/s2-core/dist/style.min.css`	389 B
`./packages/s2-core/node_modules/@testing-library/dom/dist/@testing-library/dom.cjs.js`	21.7 kB
`./packages/s2-core/node_modules/@testing-library/dom/dist/@testing-library/dom.esm.js`	21.2 kB
`./packages/s2-core/node_modules/@testing-library/dom/dist/@testing-library/dom.umd.js`	60.3 kB
`./packages/s2-core/node_modules/@testing-library/dom/dist/@testing-library/dom.umd.min.js`	33.9 kB
`./packages/s2-core/node_modules/@testing-library/dom/dist/config.js`	1.16 kB
`./packages/s2-core/node_modules/@testing-library/dom/dist/DOMElementFilter.js`	1.87 kB
`./packages/s2-core/node_modules/@testing-library/dom/dist/event-map.js`	1.18 kB
`./packages/s2-core/node_modules/@testing-library/dom/dist/events.js`	1.55 kB
`./packages/s2-core/node_modules/@testing-library/dom/dist/get-node-text.js`	300 B
`./packages/s2-core/node_modules/@testing-library/dom/dist/get-queries-for-element.js`	738 B
`./packages/s2-core/node_modules/@testing-library/dom/dist/get-user-code-frame.js`	810 B
`./packages/s2-core/node_modules/@testing-library/dom/dist/helpers.js`	1.07 kB
`./packages/s2-core/node_modules/@testing-library/dom/dist/index.js`	1.14 kB
`./packages/s2-core/node_modules/@testing-library/dom/dist/label-helpers.js`	1.05 kB
`./packages/s2-core/node_modules/@testing-library/dom/dist/matches.js`	1.14 kB
`./packages/s2-core/node_modules/@testing-library/dom/dist/pretty-dom.js`	1.47 kB
`./packages/s2-core/node_modules/@testing-library/dom/dist/queries/all-utils.js`	337 B
`./packages/s2-core/node_modules/@testing-library/dom/dist/queries/alt-text.js`	573 B
`./packages/s2-core/node_modules/@testing-library/dom/dist/queries/display-value.js`	713 B
`./packages/s2-core/node_modules/@testing-library/dom/dist/queries/index.js`	418 B
`./packages/s2-core/node_modules/@testing-library/dom/dist/queries/label-text.js`	1.8 kB
`./packages/s2-core/node_modules/@testing-library/dom/dist/queries/placeholder-text.js`	491 B
`./packages/s2-core/node_modules/@testing-library/dom/dist/queries/role.js`	2.67 kB
`./packages/s2-core/node_modules/@testing-library/dom/dist/queries/test-id.js`	498 B
`./packages/s2-core/node_modules/@testing-library/dom/dist/queries/text.js`	958 B
`./packages/s2-core/node_modules/@testing-library/dom/dist/queries/title.js`	718 B
`./packages/s2-core/node_modules/@testing-library/dom/dist/query-helpers.js`	1.81 kB
`./packages/s2-core/node_modules/@testing-library/dom/dist/role-helpers.js`	2.82 kB
`./packages/s2-core/node_modules/@testing-library/dom/dist/screen.js`	1.51 kB
`./packages/s2-core/node_modules/@testing-library/dom/dist/suggestions.js`	1.5 kB
`./packages/s2-core/node_modules/@testing-library/dom/dist/wait-for-element-to-be-removed.js`	748 B
`./packages/s2-core/node_modules/@testing-library/dom/dist/wait-for.js`	2.38 kB
`./packages/s2-react/dist/index.min.js`	67.4 kB
`./packages/s2-react/dist/style.min.css`	3.43 kB
`./packages/s2-vue/dist/index.min.js`	20.5 kB
`./packages/s2-vue/dist/style.min.css`	1.68 kB

_{compressed-size-action}

github-actions · 2023-01-09T07:38:31Z

你好, @serializedowen CI 执行失败, 请点击 [Details] 按钮查看, 并根据日志修复。

Hello, @serializedowen CI run failed, please click the [Details] button for detailed log information and fix it.

codecov · 2023-01-11T12:29:22Z

Codecov Report

Base: 77.16% // Head: 76.57% // Decreases project coverage by -0.59% ⚠️

Coverage data is based on head (c6b7169) compared to base (a4b14a8).
Patch coverage: 65.57% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2037      +/-   ##
==========================================
- Coverage   77.16%   76.57%   -0.60%     
==========================================
  Files         234      240       +6     
  Lines       11518    12229     +711     
  Branches     2449     2609     +160     
==========================================
+ Hits         8888     9364     +476     
- Misses       1258     1374     +116     
- Partials     1372     1491     +119

Impacted Files	Coverage Δ
packages/s2-core/src/cell/merged-cell.ts	`34.78% <ø> (-1.59%)`	⬇️
packages/s2-core/src/common/constant/index.ts	`90.47% <ø> (-0.60%)`	⬇️
packages/s2-core/src/common/icons/gui-icon.ts	`86.66% <ø> (-1.71%)`	⬇️
packages/s2-core/src/data-set/base-data-set.ts	`93.54% <ø> (+25.80%)`	⬆️
packages/s2-core/src/facet/header/row.ts	`85.18% <0.00%> (ø)`
packages/s2-core/src/facet/layout/node.ts	`65.16% <ø> (+2.81%)`	⬆️
...kages/s2-core/src/interaction/row-column-resize.ts	`86.53% <0.00%> (ø)`
packages/s2-core/src/sheet-type/pivot-sheet.ts	`86.11% <0.00%> (ø)`
packages/s2-core/src/sheet-type/table-sheet.ts	`89.65% <ø> (+1.72%)`	⬆️
packages/s2-core/src/utils/hide-columns.ts	`83.87% <ø> (+0.35%)`	⬆️
... and 165 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

stone-lyl · 2023-01-13T02:30:25Z

大佬的PR 能否带上图片说明😂。
如果 SelectedCellHighlight 不高亮整行时，在点击某个单元格进行复制时，也会复制整行？

packages/s2-core/src/interaction/data-cell-multi-selection.ts

packages/s2-core/__tests__/spreadsheet/table-sheet-spec.ts

github-actions · 2023-01-13T10:10:43Z

你好 @serializedowen，感谢你的贡献, 请根据模板完善 PR 描述, 并站在用户的角度说明其改动目的和解决了什么问题 (而非你的解决方式), 以便于我们可以更好的进行 Code Review, 同时请确保已关联相应 issue (如有), 检查你的 commit 是否有描述清楚你这个 PR 所做的事情。

Hello, @serializedowen, Thanks for your contribution. Please improve the PR description based on the template, and explain the purpose of the change and the problems solved from the perspective of users (not your solution), so that we can conduct a better Code Review. At the same time, please make sure corresponding issue is associated (if any) Meanwhile, please check whether your commit clearly describes what you do as a PR.

serializedowen · 2023-02-15T03:33:06Z

大佬的PR 能否带上图片说明😂。如果 SelectedCellHighlight 不高亮整行时，在点击某个单元格进行复制时，也会复制整行？

是的目前带或不带SelectedCellHighlight选项均有故障。

这个截图不是很好体现😅😅 可以切到master和目标分支试一试

lijinke666 · 2023-02-17T10:06:24Z

🎉 This PR is included in version @antv/s2-v1.41.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

lijinke666 · 2023-02-22T02:56:41Z

🎉 This PR is included in version @antv/s2-v2.0.0-next.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

* fix: 复制带双引号不再改变原始值&复制不规则单元格不再报错 * fix: 选择datacell不连带选中column coll * fix: 测试用例暂时绕过 --------- Co-authored-by: owen.wjh <[email protected]>

owen.wjh added 2 commits January 9, 2023 15:26

fix: 复制带双引号不再改变原始值&复制不规则单元格不再报错

38ce5ae

fix: 选择datacell不连带选中column coll

392af73

github-actions bot assigned serializedowen Jan 9, 2023

github-actions bot requested review from GaoFuhong, lcx-seima, lijinke666, stone-lyl, wjgogogo, xingwanying and YardWill January 9, 2023 07:29

vercel bot deployed to Preview January 9, 2023 07:32 View deployment

github-actions bot added the 🚨 test failed 单元测试挂了 label Jan 9, 2023

fix: 测试用例暂时绕过

c6b7169

vercel bot had a problem deploying to Preview January 11, 2023 11:57 Failure

github-actions bot removed the 🚨 test failed 单元测试挂了 label Jan 11, 2023

stone-lyl reviewed Jan 13, 2023

View reviewed changes

packages/s2-core/src/interaction/data-cell-multi-selection.ts Show resolved Hide resolved

stone-lyl reviewed Jan 13, 2023

View reviewed changes

packages/s2-core/__tests__/spreadsheet/table-sheet-spec.ts Show resolved Hide resolved

lijinke666 added the 👀 need more info Issue/pr 描述太少, 没有可用信息 label Jan 13, 2023

github-actions bot removed the 👀 need more info Issue/pr 描述太少, 没有可用信息 label Feb 15, 2023

stone-lyl approved these changes Feb 15, 2023

View reviewed changes

serializedowen merged commit 1c9eaa8 into master Feb 15, 2023

serializedowen deleted the fix-copy-bugs branch February 15, 2023 07:24

lijinke666 added the released label Feb 17, 2023

lijinke666 added the released on @next label Feb 22, 2023

d2FuZ3h1ZG9uZw mentioned this pull request May 14, 2023

fix(core): highlight the column header cell and row header when data cell clicked #2211

Merged

16 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

复制相关bugfix #2037

复制相关bugfix #2037

serializedowen commented Jan 9, 2023 •

edited

Loading

vercel bot commented Jan 9, 2023 •

edited

Loading

github-actions bot commented Jan 9, 2023 •

edited

Loading

github-actions bot commented Jan 9, 2023

codecov bot commented Jan 11, 2023

stone-lyl commented Jan 13, 2023

github-actions bot commented Jan 13, 2023

serializedowen commented Feb 15, 2023 •

edited

Loading

lijinke666 commented Feb 17, 2023

lijinke666 commented Feb 22, 2023

复制相关bugfix #2037

复制相关bugfix #2037

Conversation

serializedowen commented Jan 9, 2023 • edited Loading

👀 PR includes

📝 Description

🖼️ Screenshot

🔗 Related issue link

🔍 Self-Check before the merge

vercel bot commented Jan 9, 2023 • edited Loading

github-actions bot commented Jan 9, 2023 • edited Loading

github-actions bot commented Jan 9, 2023

codecov bot commented Jan 11, 2023

Codecov Report

stone-lyl commented Jan 13, 2023

github-actions bot commented Jan 13, 2023

serializedowen commented Feb 15, 2023 • edited Loading

lijinke666 commented Feb 17, 2023

lijinke666 commented Feb 22, 2023

serializedowen commented Jan 9, 2023 •

edited

Loading

vercel bot commented Jan 9, 2023 •

edited

Loading

github-actions bot commented Jan 9, 2023 •

edited

Loading

serializedowen commented Feb 15, 2023 •

edited

Loading