feat(gi-sdk): basic graph application rendering using gi-sdk #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hustcc
reviewed
Jul 24, 2024
hustcc
reviewed
Jul 24, 2024
lvisei
reviewed
Jul 24, 2024
| </Graphin> | ||
| </div> | ||
| <Panel>{snap.isReady && renderComponent('panel')}</Panel> | ||
| <Panel>{isReady && renderComponents('panel')}</Panel> |
There was a problem hiding this comment.
福老师初版实现是内置的布局，之前设计 spec 的时候有考虑过自定义布局吗？有的话，后面可以加这个 feature~
There was a problem hiding this comment.
哦，咋们这次升级是为了解决啥，slot 的设计和设计 spec 不太一样 @hustcc，后面升级可能是 breakchange
There was a problem hiding this comment.
经讨论，还是之前的spec设计更符合 sdk 的定位，下个 pr 进行修改~
lvisei
reviewed
Jul 24, 2024
| /** | ||
| * The widgets related to the graph. | ||
| */ | ||
| widgets: WidgetItem[]; |
There was a problem hiding this comment.
dataset 的设计，目前还是采用挂载到 window 的方案吗
There was a problem hiding this comment.
看了下 dataset 的类型定义对应的是一套服务的配置参数，调用服务获取数据的逻辑打算放在上层应用，gisdk专注于渲染图应用。这样设计可行吗？
There was a problem hiding this comment.
数据的定义和获取，是业务测实现，但 SDK 依赖数据才能渲染出应用来。是不是业务侧定义获取数据的资产，spec 里面声明使用那个数据资产合适一些。
yvonneyx
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
整体效果如下：
资产需要注册后使用
registerWidget('custom-sidebar', CustomSidebar);给资产提供的 API
useGISDK: 提供完整的 GISDK 上下文useGraph: 获取 G6 图实例const graph = useGraph();useGlobalModel: 获取及更新全局自定义状态const [globalModel, updateGlobalModel] = useGlobalModel()useWidgets: 获取及更新组件配置useEventSubscribe: 事件订阅useEventPublish: 事件派发