Repository navigation
fix(ci): stabilize Windows release qualification - #448
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the Windows release qualification complete reliably on hosted runners. Node is pinned to 24.21.0, which contains the libuv short-path filesystem watcher fix (nodejs/node#65118); isolated native watcher checks retain scoped exit diagnostics. The profile checker waits for the packaged renderer and IPC before inspecting Electron main state. Uninstall verification waits for both application files and registry cleanup by NSIS's temporary child process.
Application source and dependencies are unchanged. Full source gates remain blocking. All five PR contexts passed on bbde538. Hosted qualification run 34709329189 passed: 3382 tests (4 skipped), normal Windows packaging, Ed25519 manifest signing and verification, actual upgrade from 0.14.1 to 0.15.0 preserving eight settings across restarts, uninstall retaining the profile, reinstall, final uninstall, and installed payload hash checks. The downloaded final artifact also passed local signature/hash verification.
Evidence: https://github.com/antropos17/Aegis/actions/runs/34709329189. No release or tag was published.