Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade gopacket version #6972

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Upgrade gopacket version #6972

merged 1 commit into from
Feb 6, 2025

Conversation

hangyan
Copy link
Member

@hangyan hangyan commented Feb 5, 2025 •
edited
Loading

related to: #6815

@hangyan hangyan force-pushed the topic/yhang/upgrade-gopacket-dep branch from ef4e5f9 to 0a1b8cb Compare February 5, 2025 06:40
@hangyan
Copy link
Member Author

hangyan commented Feb 5, 2025 •
edited
Loading

cc @antoninbas Do you think this MR (gopacket/gopacket#99) will resolve our issue (#6815 (comment)) ?

antoninbas
antoninbas approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the e2e test issue was a timing one (test packet sent before BPF filter is installed), is that not the case?

That being said, this seems like a good / important improvement, regardless of whether or not it addresses the test flakiness issue. I see no issue with merging the PR. When gopacket 1.3.2 is actually released, dependabot should take care of picking up the new version.

@antoninbas
Copy link
Contributor

/test-all

@antoninbas antoninbas merged commit 909a97a into antrea-io:main Feb 6, 2025
59 of 62 checks passed
@hangyan
Copy link
Member Author

hangyan commented Feb 6, 2025

I thought the e2e test issue was a timing one (test packet sent before BPF filter is installed), is that not the case?

That being said, this seems like a good / important improvement, regardless of whether or not it addresses the test flakiness issue. I see no issue with merging the PR. When gopacket 1.3.2 is actually released, dependabot should take care of picking up the new version.

yeah you are right, not exactly the same issue. I will see what we can do based on the latest gopacket code.

@luolanzone luolanzone mentioned this pull request Feb 10, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoninbas antoninbas antoninbas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hangyan @antoninbas