[CNIServer] Remove stale OVS interfaces in reconcile if the original Pod interface is disconnected #6919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoninbas
reviewed
Jan 13, 2025
| } | ||
|
|
||
| // This should only happen on Windows because it is already satisfy the condition "isStaleInterface" on Linux |
There was a problem hiding this comment.
For the first sentence:
This should only happen on Windows Nodes because if this condition (OFPort is -1) is satisfied on Linux, the call to isStaleInterface above will return true, the interface will be removed, and this code will not be executed.
wenyingd
force-pushed
the
reconcile_enhancement
branch
3 times, most recently
from
82a29d6 to
5fa81a7
Compare
|
/test-all |
antoninbas
previously approved these changes
Jan 14, 2025
|
@antoninbas I have addressed your comments, could you help take another look if possible? |
jianjuns
previously approved these changes
Jan 15, 2025
…Pod interface is disconnected Signed-off-by: Wenying Dong <[email protected]>
wenyingd
force-pushed
the
reconcile_enhancement
branch
from
5fa81a7 to
5f15b8b
Compare
|
/test-all |
antoninbas
approved these changes
Jan 16, 2025
|
/test-windows-e2e |
|
The failure (http://10.164.243.223/job/antrea-windows-e2e-for-pull-request/70/console) in windows-e2e is tracked by issue #6891 |
antoninbas
added
the
action/release-note
wenyingd
added a commit
to wenyingd/antrea
that referenced
this pull request
Jan 20, 2025
…-io#6919) Signed-off-by: Wenying Dong <[email protected]>
antoninbas
pushed a commit
that referenced
this pull request
Jan 21, 2025
…#6942) Signed-off-by: Wenying Dong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.