-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding a new workflow to validate the FlexibleIPAM feature #6879
base: main
Are you sure you want to change the base?
Conversation
ccdc56f
to
ef95db6
Compare
33a2b50
to
9486da3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The title of the PR is misleading: we are adding a new workflow to validate the FlexibleIPAM feature. The fact that we use a non-default runner is an "implementation detail".
f9401e7
to
d1ba24e
Compare
422b00f
to
689f25e
Compare
689f25e
to
bee420f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few more small comments, but getting there
|
||
# Reserve IPs after 192.168.240.63 for e2e tests. | ||
if [[ $FLEXIBLE_IPAM == true ]]; then | ||
docker network create -d bridge --subnet 192.168.240.0/24 --gateway 192.168.240.1 --ip-range 192.168.240.0/26 kind |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realized that this will prevent running multiple jobs in parallel if one of them is for FlexibleIPAM. Probably not an issue, but something to keep in mind. cc @jainpulkit22
Signed-off-by: KMAnju-2021 <[email protected]>
bee420f
to
b03da08
Compare
#6887