Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding a new workflow to validate the FlexibleIPAM feature #6879

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

KMAnju-2021
Copy link
Contributor

@KMAnju-2021 KMAnju-2021 commented Dec 19, 2024

@KMAnju-2021 KMAnju-2021 marked this pull request as draft December 19, 2024 06:33
@rajnkamr rajnkamr added this to the Antrea v2.3 release milestone Dec 26, 2024
@KMAnju-2021 KMAnju-2021 force-pushed the add-cncf-runners branch 22 times, most recently from 33a2b50 to 9486da3 Compare January 2, 2025 04:30
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title of the PR is misleading: we are adding a new workflow to validate the FlexibleIPAM feature. The fact that we use a non-default runner is an "implementation detail".

.github/workflows/kind.yml Outdated Show resolved Hide resolved
ci/kind/install-ipset.sh Outdated Show resolved Hide resolved
ci/kind/kind-setup.sh Outdated Show resolved Hide resolved
ci/kind/kind-setup.sh Outdated Show resolved Hide resolved
@KMAnju-2021 KMAnju-2021 changed the title [WIP] adding self-hosted runners [WIP] adding a new workflow to validate the FlexibleIPAM feature Jan 3, 2025
.github/workflows/kind.yml Show resolved Hide resolved
.github/workflows/kind.yml Show resolved Hide resolved
ci/kind/kind-setup.sh Outdated Show resolved Hide resolved
ci/kind/kind-setup.sh Outdated Show resolved Hide resolved
ci/kind/kind-setup.sh Outdated Show resolved Hide resolved
ci/kind/kind-setup.sh Outdated Show resolved Hide resolved
ci/kind/kind-setup.sh Outdated Show resolved Hide resolved
ci/kind/kind-setup.sh Outdated Show resolved Hide resolved
ci/kind/test-e2e-kind.sh Outdated Show resolved Hide resolved
ci/kind/test-e2e-kind.sh Outdated Show resolved Hide resolved
@KMAnju-2021 KMAnju-2021 force-pushed the add-cncf-runners branch 22 times, most recently from 422b00f to 689f25e Compare February 4, 2025 06:24
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few more small comments, but getting there

ci/kind/kind-setup.sh Show resolved Hide resolved
ci/kind/kind-setup.sh Outdated Show resolved Hide resolved
ci/kind/kind-setup.sh Outdated Show resolved Hide resolved
ci/kind/kind-setup.sh Outdated Show resolved Hide resolved

# Reserve IPs after 192.168.240.63 for e2e tests.
if [[ $FLEXIBLE_IPAM == true ]]; then
docker network create -d bridge --subnet 192.168.240.0/24 --gateway 192.168.240.1 --ip-range 192.168.240.0/26 kind
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized that this will prevent running multiple jobs in parallel if one of them is for FlexibleIPAM. Probably not an issue, but something to keep in mind. cc @jainpulkit22

ci/kind/kind-setup.sh Outdated Show resolved Hide resolved
Signed-off-by: KMAnju-2021 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants