Fix PacketCapture pcapng file issue on macOS #6804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luolanzone
added
kind/bug
hangyan
force-pushed
the
fix-packetcapture-on-mac
branch
2 times, most recently
from
01870b6 to
12e1973
Compare
antoninbas
changed the title
antoninbas
reviewed
Nov 12, 2024
luolanzone
added
the
action/release-note
antoninbas
reviewed
Nov 13, 2024
hangyan
force-pushed
the
fix-packetcapture-on-mac
branch
from
e011320 to
32682e8
Compare
antoninbas
reviewed
Nov 14, 2024
antoninbas
previously approved these changes
Nov 15, 2024
There was a problem hiding this comment.
LGTM, thanks for making the changes
@tnqn do you want to take a look?
tnqn
reviewed
Nov 19, 2024
hangyan
force-pushed
the
fix-packetcapture-on-mac
branch
from
7f6c975 to
d44f261
Compare
By default, gopacket will write snap length=0 in the pcapng file header, means unlimited snaplen. tcpdump on osx(libpcap version 1.10.1) cannot recognize this and will report error. This patch will set a default value(65535) for it. Signed-off-by: Hang Yan <[email protected]>
hangyan
force-pushed
the
fix-packetcapture-on-mac
branch
from
d44f261 to
cdb9e83
Compare
|
/test-all |
|
Unrelated e2e test failures in |
|
@hangyan can you back port this PR to release 2.2. |
sure |
hangyan
added a commit
to hangyan/antrea
that referenced
this pull request
Feb 10, 2025
By default, gopacket will write snap length=0 in the pcapng file header, means unlimited snaplen. tcpdump on macOS (libpcap version 1.10.1) cannot recognize this and will report error. This patch sets a default value (65535) for it. For antrea-io#6795 Signed-off-by: Hang Yan <[email protected]>
antoninbas
added a commit
that referenced
this pull request
Feb 10, 2025
…6815) (#6821)#6804: Fix PacketCapture pcapng file issue on macOS (#6804) (#6983) * Fix packetcapture bpf filter issue (#6815) (#6821) In PacketCapture, packets which don’t match the target BPF can be received after the socket is created and before the bpf filter is applied. This patch uses a zero bpf filter (matches no packet), then empties out any packets that arrived before the "zero-BPF" filter was applied. At this point the socket is definitely empty and it can’t fill up with junk because the zero-BPF is in place. Then we replace the zero-BPF with the real BPF we want. Signed-off-by: Hang Yan <[email protected]> Co-authored-by: Antonin Bas <[email protected]> * Fix PacketCapture pcapng file issue on macOS (#6804) By default, gopacket will write snap length=0 in the pcapng file header, means unlimited snaplen. tcpdump on macOS (libpcap version 1.10.1) cannot recognize this and will report error. This patch sets a default value (65535) for it. For #6795 Signed-off-by: Hang Yan <[email protected]> --------- Signed-off-by: Hang Yan <[email protected]> Co-authored-by: Antonin Bas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, gopacket will write snap length=0 in the pcapng file header, means unlimited snaplen. tcpdump on osx(libpcap version 1.10.1) cannot recognize this and will report error. This patch will set a default value(524288) for it. This patch also add packets file verification in e2e tests.
origin error message:
pcapng format ref: https://pcapng.com/