Add methods in pkg/agent/route for NodeNetworkPolicy #5692
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hongliangl
force-pushed
the
20231110_interfaces_for_nnp_in_pkg_agent_route
branch
from
eeeb30f
to
1d39a4e
Compare
hongliangl
force-pushed
the
20231110_interfaces_for_nnp_in_pkg_agent_route
branch
2 times, most recently
from
a84569a
to
f89cec0
Compare
Add the following methods for NodeNetworkPolicy to sync iptables and ipsets: - AddOrUpdateNodeNetworkPolicyIPSet - DeleteNodeNetworkPolicyIPSet - AddOrUpdateNodeNetworkPolicyIPTables - DeleteNodeNetworkPolicyIPTables Signed-off-by: Hongliang Liu <[email protected]>
hongliangl
force-pushed
the
20231110_interfaces_for_nnp_in_pkg_agent_route
branch
from
f89cec0
to
55cad45
Compare
luolanzone
reviewed
Nov 13, 2023
| @@ -90,4 +92,16 @@ type Interface interface { | |||
|
|
|||
| // ClearConntrackEntryForService deletes a conntrack entry for a Service connection. | |||
| ClearConntrackEntryForService(svcIP net.IP, svcPort uint16, endpointIP net.IP, protocol binding.Protocol) error | |||
|
|
|||
| // AddOrUpdateNodeNetworkPolicyIPSet adds or updates ipset created for NodeNetworkPolicy. | |||
| AddOrUpdateNodeNetworkPolicyIPSet(ipsetName string, prevIPSetEntries, curIPSetEntries sets.Set[string], isIPv6 bool) error | |||
There was a problem hiding this comment.
Do we need "NodeNetworkPolicy" in the methods' name? I feel it's better to name it as a general one if the function has not to be bound with NodeNetworkPolicy.
Comment on lines
+1804
to
+1808
| if tt.isIPv6 { | ||
| _, exists = c.nodeNetworkPolicyIPSetsIPv6.Load(tt.ipsetName) | ||
| } else { | ||
| _, exists = c.nodeNetworkPolicyIPSetsIPv4.Load(tt.ipsetName) | ||
| } |
There was a problem hiding this comment.
Maybe add an internal function to reduce the code duplication.
Comment on lines
+1893
to
+1897
| if tt.isIPv6 { | ||
| _, exists = c.nodeNetworkPolicyIPTablesIPv6.Load(chain) | ||
| } else { | ||
| _, exists = c.nodeNetworkPolicyIPTablesIPv4.Load(chain) | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the following methods for NodeNetworkPolicy to sync iptables and ipsets:
Signed-off-by: Hongliang Liu [email protected]