Add iptables rule builder #5666
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch provides a simple way to build iptables rules. Signed-off-by: Hongliang Liu <[email protected]>
hongliangl
force-pushed
the
20231103-add-iptables-builder
branch
from
c1a7c12
to
312c7a5
Compare
luolanzone
reviewed
Nov 9, 2023
|
|
||
| type IPTablesRuleBuilder interface { | ||
| MatchIPSetSrc(ipset string) IPTablesRuleBuilder | ||
| MatchIPSetDst(ipset string) IPTablesRuleBuilder |
There was a problem hiding this comment.
Maybe add an empty line after each method to be more readable.
|
|
||
| "antrea.io/antrea/pkg/apis/controlplane/v1beta2" | ||
| ) | ||
|
|
There was a problem hiding this comment.
I saw there are "type Interface interface" in the iptables.go, maybe it can also be moved here?
| MatchInputInterface(eth0). | ||
| MatchTransProtocol(v1beta2.ProtocolTCP). | ||
| MatchDstPort(port8080, nil). | ||
| SetComment(`"Accept TCP 8080"`). |
There was a problem hiding this comment.
Are these double quotes required for the parameter? if yes, can we move it to inside of SetComment?
luolanzone
reviewed
Dec 6, 2023
There was a problem hiding this comment.
Looks like you already include these changes in #5658, please close this PR if it's no longer needed.
OK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch provides a simple way to build iptables rules.