Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update codegen image #339

Merged

Conversation

weiqiangt
Copy link
Contributor

Added openapi-gen installation for openapi spec generation.
Since the k8s.io/kube-openapi does not have tags, a workable commit hash is used.

Added openapi-gen installation for openapi spec generation.

Signed-off-by: Weiqiang TANG <[email protected]>
@antrea-bot
Copy link
Collaborator

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

  • /test-e2e: to trigger e2e tests.
  • /skip-e2e: to skip e2e tests.
  • /test-conformance: to trigger conformance tests.
  • /skip-conformance: to skip conformance tests.
  • /test-networkpolicy: to trigger networkpolicy tests.
  • /skip-networkpolicy: to skip networkpolicy tests.
  • /test-all: to trigger all tests.
  • /skip-all: to skip all tests.

These commands can only be run by members of the vmware-tanzu organization.

@weiqiangt
Copy link
Contributor Author

@antoninbas, could you please update the codegen image after merging this CL?

@weiqiangt
Copy link
Contributor Author

/skip-all

Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I pushed the new image to dockerhub already, no harm in doing so before this PR is merged.

What's the end goal of this PR - is this related to #323?

@weiqiangt
Copy link
Contributor Author

LGTM

I pushed the new image to dockerhub already, no harm in doing so before this PR is merged.

What's the end goal of this PR - is this related to #323?

Yes, the openapi-gen will generate the openapi spec which fixes #323.

@weiqiangt weiqiangt merged commit c96a686 into antrea-io:master Feb 3, 2020
@weiqiangt weiqiangt deleted the weiqiangt/update-codegen-image branch February 3, 2020 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants