Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated bincover with golang built-in coverage profiling tool #4962

Closed
luolanzone opened this issue May 11, 2023 · 13 comments
Closed
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lfx-mentorship Issues which have been proposed for the LFX Mentorship program

Comments

@luolanzone
Copy link
Contributor

Describe what you are trying to solve
@antoninbas reported that https://github.com/confluentinc/bincover is deprecated:

the bincover (https://github.com/confluentinc/bincover) project that we have been using for a couple of years to collect code 
coverage information when running unit tests has been deprecated. This is because starting with Go 1.20 (we still use Go 1.19 in 
Antrea, and we are waiting for Go 1.21, as we usually skip a version) there is a native way of doing the same thing: https://go.dev/testing/coverage/

Describe the solution you have in mind
We should use built-in Go coverage profiling tool https://go.dev/testing/coverage/ to replace the deprecated one once golang 1.21 is released and Antrea is upgraded to it.

@luolanzone luolanzone added the kind/design Categorizes issue or PR as related to design. label May 11, 2023
@luolanzone luolanzone added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed kind/design Categorizes issue or PR as related to design. labels May 11, 2023
@luolanzone luolanzone changed the title Replace deprecated bincover to golang built-in coverage profiling tool Replace deprecated bincover with golang built-in coverage profiling tool May 11, 2023
@github-actions
Copy link
Contributor

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment, or this will be closed in 90 days

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 10, 2023
@antoninbas antoninbas removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 10, 2023
@antoninbas
Copy link
Contributor

@luolanzone @ceclinux now that we are officially using Go v1.21, we can make progress on this issue.
It will be good to take care of this, remove the bincover dependency, and hopefully simplify code coverage measurement for e2e tests.

@ceclinux
Copy link
Contributor

@luolanzone @ceclinux now that we are officially using Go v1.21, we can make progress on this issue. It will be good to take care of this, remove the bincover dependency, and hopefully simplify code coverage measurement for e2e tests.

Sure.

@antoninbas
Copy link
Contributor

@luolanzone @ceclinux can we move forward with this issue in order to reduce tech debt?

@antoninbas antoninbas added this to the Antrea v1.15 release milestone Oct 25, 2023
@ceclinux
Copy link
Contributor

@luolanzone @ceclinux can we move forward with this issue in order to reduce tech debt?

I will take time to work on this, and it is expected to be finished in Antrea 1.16. Thanks.

@luolanzone luolanzone removed this from the Antrea v1.15 release milestone Jan 3, 2024
@VaibhavMalik4187
Copy link
Contributor

@luolanzone Can I give this a try? I have some experience with testing and code coverage collection.

@antoninbas
Copy link
Contributor

We have submitted this issue as a project idea for the LFX mentorship program: cncf/mentoring#1129. So no-one should ideally work on this issue until we know if the proposal is accepted and if we can match a mentee to work on it.
See https://docs.linuxfoundation.org/lfx/mentorship for more information on the program.

@antoninbas antoninbas added the lfx-mentorship Issues which have been proposed for the LFX Mentorship program label Jan 23, 2024
@VaibhavMalik4187
Copy link
Contributor

We have submitted this issue as a project idea for the LFX mentorship program: cncf/mentoring#1129. So no-one should ideally work on this issue until we know if the proposal is accepted and if we can match a mentee to work on it. See https://docs.linuxfoundation.org/lfx/mentorship for more information on the program.

Okay, thanks for the heads up.

@dvjsharma
Copy link

This seems intuitive! Would love the opportunity to contribute.

@anirudhprabhakaran3
Copy link

Hello! I'm considering applying to LFX for this project - looking forward to contribute! I'll poke around the good first issues so that I can get a better understanding of the code base before I apply to this project. Thanks!

@EraKin575
Copy link

Hi! I am considering applying to LFX mentorship for this project. I have some experience with code coverage and testing. I would love to explore more about Antrea and its vision and goals. Thanks!

@antoninbas
Copy link
Contributor

For all the folks who have applied or are considering applying to one of the Antrea projects for the LFX mentorship program, we have published instructions to complete test tasks: #5976. We will review your submissions for these tasks alongside other material (resume, cover letter) when selecting mentees. The deadline for submitting is February 20th 5PM PST.

Dhanush0369 added a commit to Dhanush0369/antrea that referenced this issue Feb 11, 2024
VaibhavMalik4187 added a commit to VaibhavMalik4187/antrea that referenced this issue Feb 14, 2024
This commit includes files obtained by following instructions at:
antrea-io#5976 for the proposal:
antrea-io#4962.

The `controllerinfo.txt` file contains the ouput obtained by running the
custom-built Antrea CLI binary to retrieve controller information.

The `coverage.txt` file shows the fraction of statements in the
`antrea.io/antrea/pkg/antctl` package executed by running:
`./bin/my-antctl get controllerinfo`.

Signed-off-by: VaibhavMalik4187 <[email protected]>
@antoninbas
Copy link
Contributor

@shikharish will work on this as part of the LFX mentorship program

shikharish added a commit to shikharish/antrea that referenced this issue May 10, 2024
shikharish added a commit to shikharish/antrea that referenced this issue May 11, 2024
shikharish added a commit to shikharish/antrea that referenced this issue May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lfx-mentorship Issues which have been proposed for the LFX Mentorship program
Projects
None yet
Development

No branches or pull requests

7 participants