-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate CRDs labels in validating webhook #3285
Labels
kind/design
Categorizes issue or PR as related to design.
Comments
GraysonWu
added a commit
to GraysonWu/antrea
that referenced
this issue
Feb 17, 2022
Fixes antrea-io#3285. This PR added some additional validations to ANP and ACNP in validating webhook. Antrea will validate labels used in ANP and ACNP under PodSelector, NamespaceSelector and ExternalEntitySelector. Signed-off-by: wgrayson <[email protected]>
GraysonWu
added a commit
to GraysonWu/antrea
that referenced
this issue
Feb 17, 2022
Fixes antrea-io#3285. This PR added some additional validations to ANP and ACNP in validating webhook. Antrea will validate labels used in ANP and ACNP under PodSelector, NamespaceSelector and ExternalEntitySelector. Signed-off-by: wgrayson <[email protected]>
GraysonWu
added a commit
to GraysonWu/antrea
that referenced
this issue
Feb 17, 2022
Fixes antrea-io#3285. This PR added some additional validations to ANP and ACNP in validating webhook. Antrea will validate labels used in ANP and ACNP under PodSelector, NamespaceSelector and ExternalEntitySelector. Signed-off-by: wgrayson <[email protected]>
GraysonWu
added a commit
to GraysonWu/antrea
that referenced
this issue
Feb 22, 2022
Fixes antrea-io#3285. This PR added some additional validations to ANP and ACNP in validating webhook. Antrea will validate labels used in ANP and ACNP under PodSelector, NamespaceSelector and ExternalEntitySelector. Signed-off-by: wgrayson <[email protected]>
GraysonWu
added a commit
to GraysonWu/antrea
that referenced
this issue
Feb 24, 2022
Fixes antrea-io#3285. This PR added some additional validations to ANP, ACNP and CG in validating webhook. Antrea will validate labels used in ANP, ACNP and CG under PodSelector, NamespaceSelector and ExternalEntitySelector. Signed-off-by: wgrayson <[email protected]>
tnqn
pushed a commit
that referenced
this issue
Feb 24, 2022
Fixes #3285. This PR added some additional validations to ANP, ACNP and CG in validating webhook. Antrea will validate labels used in ANP, ACNP and CG under PodSelector, NamespaceSelector and ExternalEntitySelector. Signed-off-by: wgrayson <[email protected]>
bangqipropel
pushed a commit
to bangqipropel/antrea
that referenced
this issue
Mar 2, 2022
Fixes antrea-io#3285. This PR added some additional validations to ANP, ACNP and CG in validating webhook. Antrea will validate labels used in ANP, ACNP and CG under PodSelector, NamespaceSelector and ExternalEntitySelector. Signed-off-by: wgrayson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe what you are trying to solve
Currently while creating K8s resources, for example, Pod, k8s NeworkPolicy, etc., the API server will validate if labels used in those resources are valid. For example, if I use an invalid character '=', it will return:
But now our CRDs with invalid labels can be accepted, for example, the acnp below:
This ACNP won't have any effect since no Pod will have this invalid label
app: foo=bar
. But Antrea will still waste computing resource to process this ACNP.Describe the solution you have in mind
I'm wondering if we could add this validation in out validating webhook?
Idea comes from here
The text was updated successfully, but these errors were encountered: