Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the labels at any time once the sublayers are added #11

Closed
AlexanderNorway opened this issue Aug 31, 2016 · 4 comments
Closed

Comments

@AlexanderNorway
Copy link

AlexanderNorway commented Aug 31, 2016

I have a case where I depending on which step the user is on, will need to change the text of the previous step to "V" as in "Done". Any suggestions on how to achieve this without the code becoming very hacky? Also, would be awesome to have both a label inside the circle and a subtitle label underneath the circle.

@AlexanderNorway AlexanderNorway changed the title Changing the labels at any time once sublayers are added Changing the labels at any time once the sublayers are added Aug 31, 2016
antoninbiret added a commit that referenced this issue Aug 31, 2016
@antoninbiret
Copy link
Owner

antoninbiret commented Aug 31, 2016

Hi Alexander,

If I understood the question correctly, you will find my way of doing it on the exemple project (more precisely in ExempleViewController.swift) on this branch. It's not really hacky and do the job ;)

For the suggestion, I think this fits only your needs and I don't really want to add complexity for that. However, what we could do is adding a function which gives you the frame (or center position) of each step. With this frame/position you could easily layout your subtitle labels (I made an exemple in this commit). What do you think about it ?

@aliasbody
Copy link

I have the exact same problem, I mean that just providing the Bullet CGPoint for the current index should be a good start in order for us to handle the presentation of a small label at the top as a subtitle.

@antoninbiret
Copy link
Owner

antoninbiret commented Sep 6, 2016

You should use the branch feature/issue-#11 for now. I'll create a new version tonight with the center points accessor.

@aliasbody
Copy link

@antoninbiret Thanks, i'll do that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants