Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tracing_subscriber problem in kona-derive tests #741

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

steph-rs
Copy link
Contributor

This PR provides fix for tracing_subscriber initialization at kona-derive tests.
command to reproduce:

cd crates/derive; cargo test 

the result:

---- batch::span_batch::batch::tests::test_check_batch_exceeds_sequencer_time_drift stdout ----
thread 'batch::span_batch::batch::tests::test_check_batch_exceeds_sequencer_time_drift' panicked at .cargo/registry/src/index.crates.io-6f17d22bba15001f/tracing-subscriber-0.3.18/src/util.rs:91:14:
failed to set global default subscriber: SetGlobalDefaultError("a global default trace dispatcher has already been set")
...
  
test result: FAILED. 216 passed; 34 failed; 1 ignored; 0 measured; 0 filtered out; finished in 0.02s

with this fix:

test result: ok. 250 passed; 0 failed; 1 ignored; 0 measured; 0 filtered out; finished in 0.05s

Copy link
Collaborator

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice catch!

@refcell refcell added this pull request to the merge queue Oct 28, 2024
Merged via the queue into anton-rs:main with commit ba454b5 Oct 28, 2024
14 of 15 checks passed
This was referenced Oct 29, 2024
@steph-rs steph-rs deleted the fix/kona-derive-tests branch October 29, 2024 20:32
TomTaehoonKim pushed a commit to TomTaehoonKim/kona that referenced this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants