Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kona-derive): Remove SignedRecoverable Shim #400

Merged
merged 6 commits into from
Jul 26, 2024
Merged

fix(kona-derive): Remove SignedRecoverable Shim #400

merged 6 commits into from
Jul 26, 2024

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Jul 26, 2024

Description

Previously, building the kona-derive crate would fail with --no-default-features since the tx envelope's public key recovery method is only available when the k256 feature is enabled on alloy consensus.

This removes the SignedRecoverable trait shim and requires that k256 is enabled.

We will need to refactor kona-derive sources to be abstract over the signer recovery method so we're not locked into k256.

@refcell refcell self-assigned this Jul 26, 2024
@refcell refcell requested a review from clabby July 26, 2024 14:15
@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.8%. Comparing base (5c30c4c) to head (4ea00d4).
Report is 1 commits behind head on main.

Files Patch % Lines
crates/derive/src/sources/blobs.rs 0.0% 1 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@refcell refcell added A-derive Area: kona-derive crate K-fix Kind: fix labels Jul 26, 2024
@refcell refcell added this to the Maintenance: Nice to Have milestone Jul 26, 2024
@refcell refcell changed the title fix(kona-derive): Place Public Key Recovery behind k256 Feat Flag fix(kona-derive): Remove SignedRecoverable Shim Jul 26, 2024
bin/client/Cargo.toml Outdated Show resolved Hide resolved
@refcell refcell requested a review from clabby July 26, 2024 15:19
crates/derive/src/sources/calldata.rs Outdated Show resolved Hide resolved
@clabby clabby enabled auto-merge July 26, 2024 15:30
@clabby clabby added this pull request to the merge queue Jul 26, 2024
Merged via the queue into main with commit 4c367d8 Jul 26, 2024
19 checks passed
@github-actions github-actions bot mentioned this pull request Jul 26, 2024
@github-actions github-actions bot mentioned this pull request Aug 16, 2024
@github-actions github-actions bot mentioned this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-derive Area: kona-derive crate K-fix Kind: fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants