-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(kona-derive): Remove SignedRecoverable Shim #400
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files☔ View full report in Codecov by Sentry. |
refcell
changed the title
fix(kona-derive): Place Public Key Recovery behind k256 Feat Flag
fix(kona-derive): Remove SignedRecoverable Shim
Jul 26, 2024
clabby
reviewed
Jul 26, 2024
clabby
approved these changes
Jul 26, 2024
clabby
reviewed
Jul 26, 2024
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, building the
kona-derive
crate would fail with--no-default-features
since the tx envelope's public key recovery method is only available when thek256
feature is enabled on alloy consensus.This removes the
SignedRecoverable
trait shim and requires thatk256
is enabled.We will need to refactor
kona-derive
sources to be abstract over the signer recovery method so we're not locked intok256
.