Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(derive): Remove noisy batch logs #329

Merged
merged 1 commit into from
Jun 27, 2024
Merged

chore(derive): Remove noisy batch logs #329

merged 1 commit into from
Jun 27, 2024

Conversation

clabby
Copy link
Collaborator

@clabby clabby commented Jun 27, 2024

Overview

Removes the noisy batch logs in info! / warn! log levels within the BatchQueue. These cause a significant slowdown due to having to Debug format the entire batch, which can be tens of megabytes large when decompressed.

## Overview

Removes the noisy batch logs in `info!` / `warn!` log levels within the
`BatchQueue`. These cause a significant slowdown due to having to
`Debug` format the entire batch, which can be tens of megabytes large
when decompressed.
@clabby clabby self-assigned this Jun 27, 2024
@clabby clabby added K-chore Kind: chore A-derive Area: kona-derive crate labels Jun 27, 2024
Copy link
Collaborator Author

clabby commented Jun 27, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @clabby and the rest of your teammates on Graphite Graphite

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.8%. Comparing base (72dc3fc) to head (ac50572).

Files Patch % Lines
crates/derive/src/stages/batch_queue.rs 50.0% 1 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@refcell refcell added this pull request to the merge queue Jun 27, 2024
Merged via the queue into main with commit d3f1493 Jun 27, 2024
14 checks passed
@github-actions github-actions bot mentioned this pull request Jun 27, 2024
@clabby clabby deleted the cl/batch-info-spam branch July 2, 2024 03:36
This was referenced Jul 8, 2024
@github-actions github-actions bot mentioned this pull request Aug 16, 2024
@github-actions github-actions bot mentioned this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-derive Area: kona-derive crate K-chore Kind: chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants