Skip to content

test#3

Closed
anton-evseev wants to merge 1 commit intonetwork-february-releasefrom
ci-test
Closed

test#3
anton-evseev wants to merge 1 commit intonetwork-february-releasefrom
ci-test

Conversation

@anton-evseev
Copy link
Copy Markdown
Owner

@anton-evseev anton-evseev commented Mar 4, 2019

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

anton-evseev pushed a commit that referenced this pull request Feb 19, 2020
@anthonykjose @tonykjose
Add encryption scope API to 2019-06-01. (Azure#8381)
74cf8e9 
* Add encryption scope API to 2019-06-01.

Add encryption scope API to 2019-06-01.

* Address CI failures.

* Fix CI failures #2.

* Address CI failures #3.

Co-authored-by: Anthony Kunnel Jose <antjo@microsoft.com>
anton-evseev pushed a commit that referenced this pull request Mar 18, 2020
@ctaggart @sigmer @et1975
VMware by Virtustream API 2019-08-09-preview (Azure#8296)
f9af8f5 
* 2019-08-09-preview

* spell out networks

* username and credential needed to add an IdentitySource

* post listAdminCredentials

* standardize on username, password, nsxt and vcenter

* add nsxt to custom-words.txt

* default cluster does not have provisioningState

* it extends DefaultClusterProperties

* add Circuit expressRoutePrivatePeeringID

* back out some minor changes for sdk generation

* identitySources and Circuit authorizations are updateable

* add PrivateClouds_ListInSubscription

* Long running operation for Clusters_Delete (#1)

* npm run prettier

* location for all resources (#2)

* Revert "location for all resources (#2)" (#3)

This reverts commit 432e37b.

* add description TODOs

* example is PrivateClouds_Update

* require body in PrivateClouds_Update

* replaced TODOs with descriptions

* spellcheck

* "x-ms-secret": true

* Revert ""x-ms-secret": true"

This reverts commit 3358dff.

Co-authored-by: Andrew Ulliani <aulliani@yahoo.com>
Co-authored-by: Eugene Tolmachev <e.tolmachev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@anton-evseev