Fix segmentation fault due to varargs on Apple M1 #48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling conventions on Apple M1 seem to differ for varargs: the program below prints "The answer is " on M1 while it prints "The answer is 42" on Linux.
This commit fixes all type annotations for functions that are extracted from
ap_manager_t*
. This solves segmentation faults observed when apron is compiled on Apple M1.Another solution would have been to use the type
void (*ptr)()
, but expliciting types look like a safer approach. Types allow us to find and fix the following suspicious line (apron/ap_generic.c
, line 167):whereas
copy
isAP_FUNID_COPY
of typevoid* (*copy)(ap_manager_t*,void*)
(the argumentman
was obviously missing).