-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apron wrapper for PPLite 0.12. #105
Conversation
Strip non-debug libraries.
Patch contributed by Michele Spotti. This renaming is needed to avoid a name clash with (version 3 of) the FLINT library, which is a required dependency when enabling PPLite. Note: name clash is caused by functions matrix_clear and matrix_equal.
Thanks for the PR! I tried it although I still havePPLite 0.11 (not 0.12) and I get errors in
Is this expected? Do you have a plan so that the binding works with both versions 0.11and 0.12, or would it be unadvisable? |
It was expected, as the PPLite's interface has changed. |
Thanks, that'd be perfect! Alternatively, if it makes more sense to make it work only for 0.12, it's also OK, but the |
(Maybe) Define macro HAVE_PPLITE_0_11 at configuration time. Added a couple of backward compatibility helpers.
Thanks! |
Sorry, another thing: I think that |
Done, thank you. |
Thank you very much! I think this is ready to be merged. |
PPLite version 0.12 no longer depends on gmpxx (the C++ interface of GMP).
Note: we also applied a minor renaming to newpolka matrix_* type and functions (adding prefix "pk_") so as to avoid a few name clashes with version 3 of the FLINT library, which is a required dependency of PPLite. Both newpolka and FLINT v.3 have functions named "matrix_clear" and "matrix_equal", thereby preventing static linking of Apron and PPLite when using the newer version of FLINT. Fix contributed by Michele Spotti.