Feat/yaml config file #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoineauger
force-pushed
the
feat/yaml-config-file
branch
from
c742f1d to
7e6a316
Compare
antoineauger
force-pushed
the
feat/yaml-config-file
branch
2 times, most recently
from
fff8716 to
ddf27b4
Compare
antoineauger
force-pushed
the
feat/yaml-config-file
branch
from
ddf27b4 to
c5a0441
Compare
|
@nejch @max-wittig This is ready for a first "internal" review round 🏓 |
|
Superseded by vllm-project#621, closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now this MR targets my fork, let's do an "internal" review round before we submit this upstream