Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-target .NET Standard 2.0 and .NET Framework 4.5 #118

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

WilStead
Copy link

@WilStead WilStead commented Jul 1, 2018

This PR adds multi-targeting for netstandard2.0 and net45, in order to support use of Migrant in .NET Standard projects.

Summary of changes:

  • The sln and csproj files are updated to the VS2017 format to permit the .NET Standard multi-targeting, including moving info from AssemblyInfo.cs to the project files.
  • Only one method is not currently supported by .NET Standard 2.0: DumpToLibrary<T> in Generators/GeneratorHelper.cs. This method is unused internally, even by tests. Compiler conditionals are used to restrict its use to the net45 target; for the netstandard2.0 target an Obsolete attribute is added and the method throws a NotImplementedException if called.
  • The second module test project had to be moved out of its position nested within the main test project and placed into its own top-level folder, due to a bug in the way the new project format handles automatic assembly info generation.

All tests verified passing after the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant