Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Fix #3882 -- TypeScript target testing broken. #3883

Merged
merged 2 commits into from
Dec 11, 2023
Merged

[build] Fix #3882 -- TypeScript target testing broken. #3883

merged 2 commits into from
Dec 11, 2023

Conversation

kaby76
Copy link
Contributor

@kaby76 kaby76 commented Dec 11, 2023

This is a fix for #3882.

Fixed illegal import declaration for TypeScript. Touched the vba grammar to demo fix (as we saw it broken with https://github.com/antlr/grammars-v4/actions/runs/7159898459/job/19493663604)

In addition, the templates for building were changed to reference a specific version of the typescript package, so we don't hit this problem again when MS has a new release.

Fixed illegal import declaration for TypeScript. Touched the vba grammar to force build of the to demo fix.
This was referenced Dec 11, 2023
@kaby76
Copy link
Contributor Author

kaby76 commented Dec 11, 2023

All set.

@teverett
Copy link
Member

@kaby76 thanks!

@teverett teverett merged commit c36b614 into antlr:master Dec 11, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants