Conversation
…f DFA collections Signed-off-by: Jim.Idle <jimi@idle.ws>
Also corrects the formatting of some of the files as this can create false compares in git. Signed-off-by: Jim.Idle <jimi@idle.ws>
…er look Signed-off-by: Jim.Idle <jimi@idle.ws>
…in some cases Signed-off-by: Jim.Idle <jimi@idle.ws>
…each run Signed-off-by: Jim.Idle <jimi@idle.ws>
Member
|
yay! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: Memory usage improvements, performance and statistics
Badly formed grammars will see some small improvements in memory usage and performance, though I doubt that this is a lot. I have been using the mysql contributed grammar as an example of the worst runtime case. But I also used release build flags rather than the default go ones:
@kaby76 - maybe you can change your build rig to use the go flags above. It can make a difference in some cases, especially on good grammars.
From here, I will concentrate on rewarding well formed grammars. I am disinclined to spend more time on the worst cases for the moment, until the statistics package that this PR implements is fully implemented.
@parrt - if you would please merge this when you have a chance?