[Javascript] Added support for commonjs in nodejs package

[Tarjei400]

No package should enforce upon creator a need to migrate to ESM. As per this pull request, I added webpack configuration that produces cjs and mjs files Correspoding to CommonJS and ESM module. After this pull request if will be up to a project which one to use.

Cheers!

[ericvergnaud]

Hey, nobody's enforcing anything, and we welcome contributors. Let's see how this works for other devs looking for CommonJS support.

[NilsBaumgartner1994]

@Tarjei400 thank you :-) will have a look. @ericvergnaud thanks for notification.

[Tarjei400]

@enessoylu I just mean that at the moment library requires ESM in a project and this is "enforcing" ESM in a project, I didnt mean anyone per se :P Anyways thanks for taking a look, I think it will be a usefull addition for this package!

[jharris4]

I think adding exports to the package.json is a step in the right direction.

Following down this path should help with the TypeScript target as well. For example as of TypeScript 5.0 you can do the following with exports in your package.json to export separate types for node and web:

{
  "exports": {
    ".": {
      "node": {
        "types": "src/index.node.d.ts",
        "default": "dist/bundle.node.js"
      },
      "browser": {
        "types": "src/index.web.d.ts",
        "default": "dist/bundle.web.js"
      }
    }
  }
}

And with TypeScript 5 the package entry point & types can be toggled in the tsconfig.json by changing compilerOptions.moduleResolution between nodenext and bundler.

TypeScript docs

NodeJS docs

[Tarjei400]

@jharris4 I will take a look later this afternoon for all cases you mentioned , however in my case I can only import cjs file in node project.

[Tarjei400]

@jharris4 Sorry it took some time. I checked that export solution and added tests for nodejs esm/commonjs and updated PR

[ericvergnaud]

I could use an explanation of the code in this file. Why can't we just write "require('antlr4')" ?

[Tarjei400]

Right, I just transpiled it with ts, but you are right require will do the job. Changed 👍

[ericvergnaud]

exten*t*ions or extensions ?

[Tarjei400]

Type, fixed

[ericvergnaud]

If I understand correctly, this PR would generate esm and cjs for web and node, without touching any runtime code ? Sounds promising! Awaiting for my inline comments to be addressed.

[Tarjei400]

Correct @ericvergnaud :D Addressed your comments!

[ericvergnaud]

Good stuff! Thanks so much, I know for sure this will make many developers happy.
@parrt blessed

[Tarjei400]

Myself included :D Also thanks for this great tool!

[ericvergnaud]

Fixes #4211

[jedwards1211]

@Tarjei400 big thanks for this 😊

[NilsBaumgartner1994]

NiceBeste Grüße,Nils BaumgartnerAm 10.11.2023 um 09:43 schrieb Andy Edwards ***@***.***>: @Tarjei400 big thanks for this 😊 —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: ***@***.***>