Update LexerATNSimulator.cs with virtual Consume#4197
Merged
parrt merged 1 commit intoantlr:masterfrom Mar 21, 2023
cx-alberto-simoes:PR/VirtualConsume
Merged
Update LexerATNSimulator.cs with virtual Consume#4197parrt merged 1 commit intoantlr:masterfrom cx-alberto-simoes:PR/VirtualConsume
parrt merged 1 commit intoantlr:masterfrom
cx-alberto-simoes:PR/VirtualConsume
Conversation
cx-alberto-simoes
changed the title
Allow user to subclass and consume differently. Useful for CR handling as suggested in #2519 Signed-off-by: Alberto Simões <Alberto.Simoes@checkmarx.com>
Contributor
Author
|
I understand this is a very small change, but if this gets accepted, a minor release would be very welcome. |
Contributor
|
@parrt blessed |
Contributor
Author
|
Do we have a tentative date for 4.12.1? |
Member
|
unfortunately not. Kinda waiting on Go updates. |
Collaborator
|
I’ll be ready this week. I can pause optimizations Friday if you want to
get a release out?
…On Wed, Mar 29, 2023 at 08:59 Terence Parr ***@***.***> wrote:
unfortunately not. Kinda waiting on Go updates.
—
Reply to this email directly, view it on GitHub
<#4197 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJ7TMETX7QT7H5YZ3O4LO3W6OCNTANCNFSM6AAAAAAWA7DNA4>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Contributor
Author
|
That would be nice. Waiting for that release :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow user to subclass and consume differently. Useful for CR handling as suggested in #2519