Skip to content

Remove redundant source code from go runtime#4155

Merged
parrt merged 2 commits intoantlr:devfrom
jimidle:feature/v4cleanup
Mar 5, 2023
Merged

Remove redundant source code from go runtime#4155
parrt merged 2 commits intoantlr:devfrom
jimidle:feature/v4cleanup

Conversation

@jimidle
Copy link
Collaborator

@jimidle jimidle commented Mar 5, 2023

Removes the non /v4 source code from the runtime and marks the original go.mod file as redundant

jimidle added 2 commits March 5, 2023 17:41
…rce must be under /v4 for modules

Signed-off-by: Jim.Idle <jimi@idle.ws>
…recated

Signed-off-by: Jim.Idle <jimi@idle.ws>
@jimidle jimidle force-pushed the feature/v4cleanup branch from 3857e16 to 1fc779c Compare March 5, 2023 09:41
@jimidle
Copy link
Collaborator Author

jimidle commented Mar 5, 2023

@parrt This is the cleanup PR that will leave us with only one v4 source code for the go runtime.

@parrt parrt added this to the 4.12.1 milestone Mar 5, 2023
@parrt
Copy link
Member

parrt commented Mar 5, 2023

Thanks, Jim!

@parrt parrt merged commit 7cd68d5 into antlr:dev Mar 5, 2023
@jimidle jimidle deleted the feature/v4cleanup branch March 6, 2023 02:28
jimidle pushed a commit to jimidle/antlr4 that referenced this pull request Mar 28, 2023
* feat: Remove the old version of the source code, as at v4.x.y the source must be under /v4 for modules

Signed-off-by: Jim.Idle <jimi@idle.ws>

* fix: tidy up old version of go.mod (non v4 version), which is now deprecated

Signed-off-by: Jim.Idle <jimi@idle.ws>

---------

Signed-off-by: Jim.Idle <jimi@idle.ws>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants