Don’t specify a default type for the exported Swift package library#3953
Merged
Don’t specify a default type for the exported Swift package library#3953
Conversation
Signed-off-by: Tony Arnold <tony@thecocoabots.com>
tonyarnold
force-pushed
the
swift-pm-no-default-type
branch
from
cb5ad84 to
44761bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes removing the
type: .dynamicproperty of the main library exported from the Swift package.Forcing the type of the library means that the project will always be generated as a framework bundle, which is fine for application targets, but complicates CLI targets.
Xcode includes smarts to determine what the appropriate type is to use, and the library does not appear to make use of any framework-specific features like resource bundling, so this should be a low impact change for users of the library.