Feature/gomod4110#3852
Merged
Conversation
added 3 commits
August 31, 2022 14:44
Signed-off-by: Jim.Idle <jimi@gatherstars.com>
Signed-off-by: Jim.Idle <jimi@gatherstars.com>
…ase tagging Note that the vast majority of the changes here are just copying the runtime file in to the /v4 subdirectory so that we can support legacy projects that use GOPATH only, as well as users that can use go modules. At a later release, we will delete the default path, and move the v4 subdirectory back to the top level. But, we cannot do that on this release. Signed-off-by: Jim.Idle <jimi@gatherstars.com>
Member
|
Looks good to me but let's synchronize so I don't screw this up. Oh, sorry emerged something related to the test rig from @KvanTTT and so there's a conflict you might want to resolve quickly. |
Member
|
Ok, looking good on Go target...merging! |
Member
|
@jimidle shouldn't we delete the non-v4 version of the Go code? |
Collaborator
Author
|
Next release. I want to play it safe for existing projects. When I am sure
that v4 is good, we can then delete the code and clean up the repo.
…On Mon, Sep 5, 2022 at 02:05 Terence Parr ***@***.***> wrote:
@jimidle <https://github.com/jimidle> shouldn't we delete the non-v4
version of the Go code?
—
Reply to this email directly, view it on GitHub
<#3852 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJ7TMAM4PK26PNQA2EKGRLV4TQGFANCNFSM6AAAAAAQBF7U6A>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: #3840 Implement go runtime v4 path correctly so that release tags work.
Though this PR will seem like a huge change, in fact most of the changes are just copying the existing runtime module to a new module path
github.com/antlr/antlr4/runtime/Go/antlr/v4so that Go runtime tags will actually work in this release.The actual changes are:
v4pathNB Though the runtime path changes to
v4the public runtime API has not changed and it is very little work to changeto use the new module path. Most go programmers will know how to do this, but it is also documented.