Fix CMake syntax for variable expansion#3777
Conversation
When using variables to compare (like in if clause) the variable shouldn't be quoted. More details can be found at the link below: https://cmake.org/cmake/help/latest/command/if.html#variable-expansion Signed-off-by: HS <hs@apotell.com>
|
@parrt Any reason why there's no Windows check build for Cpp runtime? I was looking thru' the CI as to why these issues go unnoticed and never get caught in CI. I am not seeing a Cpp runtime CI check build for Windows. https://github.com/antlr/antlr4/actions/runs/2624274002 |
|
I think @parrt would be happy if there was a contribution for a Windows CI ... |
|
Heh, thanks! @KvanTTT have you had any luck with CI for windows & C++? |
|
Is there a reason (apart from not finding a volunteer) Windows CI for runtime Cpp was excluded? Was it attempted and have known issues? |
|
it just needs someone to give it a go
… Le 7 juil. 2022 à 01:07, HS ***@***.***> a écrit :
Is there a reason (apart from not finding a volunteer) Windows CI for runtime Cpp was excluded? Was it attempted and have known issues?
—
Reply to this email directly, view it on GitHub <#3777 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAZNQJHLSLI6S6E6IYBJBTTVSYGR3ANCNFSM522UNKTA>.
You are receiving this because you are subscribed to this thread.
|
|
I've already wrote I don't know how to install msbuild on CI machine: #3725 (comment) It requires admin access. Also, I don't have access to Windows CI self-hosted server. Except of that, there are no other problems with Windows C++ tests, they should work. At least they work fine locally (PATH should be set up to msbuild directory). |
5 participants
When using variables to compare (like in if clause) the variable
shouldn't be quoted. More details can be found at the link below:
https://cmake.org/cmake/help/latest/command/if.html#variable-expansion
Signed-off-by: HS hs@apotell.com